Hide admin_menu when viewing click heatmaps

mcrittenden - June 28, 2009 - 14:45
Project:Click HeatMap
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:boombatower
Status:closed
Description

If you use this module with admin_menu enabled, then when you view the click heatmap, the clicks will appear to be about 18 pixels higher than they really were because the heatmap shows admin_menu which pushes the body down, but the users don't see that so the body is actually 18px higher for them.

I don't know if this is really within your control since I guess this module probably just embeds the page as the background of the flash file without the ability to do any rendering to it, but I thought I'd check anyway.

Thanks!

#1

boombatower - June 28, 2009 - 19:55
Status:active» postponed (maintainer needs more info)

Yea it just uses an iframe to load page for background.

One options might be the ability to disable the admin menu in iframe...admin_menu would need some sort of switch.

#2

mcrittenden - June 29, 2009 - 02:21
Title:admin_menu throws off click locations» admin_menu throws off click locations in Click HeatMap
Project:Click HeatMap» Administration menu
Version:6.x-2.5» 6.x-3.x-dev
Component:User interface» Code
Status:postponed (maintainer needs more info)» active

Transferring to admin_menu issue queue to see what sun thinks about your suggestion.

#3

sun - July 1, 2009 - 19:22
Status:active» postponed (maintainer needs more info)

I don't understand whether the problem is inside of the the IFRAME or outside.

If it is inside, then you can probably just do:

<?php
module_invoke
('admin_menu', 'suppress');
?>

as early as possible in the request before hook_footer() is invoked.

If it is outside, then it gets harder. You might check for the CSS class body.admin-menu to dynamically alter the margin.

#4

mcrittenden - July 2, 2009 - 18:03
Project:Administration menu» Click HeatMap
Version:6.x-3.x-dev» 6.x-2.5
Status:postponed (maintainer needs more info)» active

It's inside. With that comment in mind, I'm going to move back over to Click Heatmap.

Thanks, sun.

#5

boombatower - September 28, 2009 - 07:09
Version:6.x-2.5» 6.x-2.x-dev
Category:bug report» feature request
Assigned to:Anonymous» boombatower
Status:active» needs review

Finally got around to cleaning up this module a bit.

AttachmentSize
504504-hide-admin-menu.patch 1.18 KB

#6

boombatower - September 28, 2009 - 07:10
Title:admin_menu throws off click locations in Click HeatMap» Hide admin_menu when viewing click heatmaps
Status:needs review» fixed

Committed.

#7

mcrittenden - September 28, 2009 - 12:44

Thanks!

#8

System Message - October 12, 2009 - 12:50
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.