If you use this module with admin_menu enabled, then when you view the click heatmap, the clicks will appear to be about 18 pixels higher than they really were because the heatmap shows admin_menu which pushes the body down, but the users don't see that so the body is actually 18px higher for them.

I don't know if this is really within your control since I guess this module probably just embeds the page as the background of the flash file without the ability to do any rendering to it, but I thought I'd check anyway.

Thanks!

CommentFileSizeAuthor
#5 504504-hide-admin-menu.patch1.18 KBboombatower

Comments

boombatower’s picture

boombatower commented
Status: Active » Postponed (maintainer needs more info)

Yea it just uses an iframe to load page for background.

One options might be the ability to disable the admin menu in iframe...admin_menu would need some sort of switch.

mcrittenden’s picture

mcrittenden commented
Title: admin_menu throws off click locations » admin_menu throws off click locations in Click HeatMap
Project: Click HeatMap » Administration menu
Version: 6.x-2.5 » 6.x-3.x-dev
Component: User interface » Code
Status: Postponed (maintainer needs more info) » Active

Transferring to admin_menu issue queue to see what sun thinks about your suggestion.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Active » Postponed (maintainer needs more info)

I don't understand whether the problem is inside of the the IFRAME or outside.

If it is inside, then you can probably just do:

module_invoke('admin_menu', 'suppress');

as early as possible in the request before hook_footer() is invoked.

If it is outside, then it gets harder. You might check for the CSS class body.admin-menu to dynamically alter the margin.

mcrittenden’s picture

mcrittenden commented
Project: Administration menu » Click HeatMap
Version: 6.x-3.x-dev » 6.x-2.5
Status: Postponed (maintainer needs more info) » Active

It's inside. With that comment in mind, I'm going to move back over to Click Heatmap.

Thanks, sun.

boombatower’s picture

boombatower commented
Version: 6.x-2.5 » 6.x-2.x-dev
Assigned: Unassigned » boombatower
Category: bug » feature
Status: Active » Needs review
StatusFileSize
new 504504-hide-admin-menu.patch1.18 KB

Finally got around to cleaning up this module a bit.

boombatower’s picture

boombatower commented
Title: admin_menu throws off click locations in Click HeatMap » Hide admin_menu when viewing click heatmaps
Status: Needs review » Fixed

Committed.

mcrittenden’s picture

mcrittenden commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Sten-dupe’s picture

Sten-dupe commented
Version: 6.x-2.x-dev » 6.x-2.6

Hi I have the same issue on the 2.6 version. I checked the patch and its the same. If this has been added why am I still seeing the admin menus?

Thanks for your help.

andb’s picture

andb commented
Status: Closed (fixed) » Active

I can confirm Sten's report that in 2.6 the admin menu bar is showing again. I've checked the code and the patched code is in the module, but the admin menu still renders in the reports. Re-opening.

mcrittenden’s picture

mcrittenden commented
Status: Active » Needs work

Issues should be CNW if there is already a patch attached.

guybedford’s picture

guybedford commented

I had this issue as well. Turned out there was a simple js error in the code. I've noted the correction here:

http://drupal.org/node/771080

That resolved the issue for me.

mcrittenden’s picture

mcrittenden commented
Status: Needs work » Closed (duplicate)

Then marking as duplicate of #771080: JS Error: extra closing parenthesis since the fix is there.