Multiple banks

current status:
you can use the "Payment instructions" and add as many banks(text lines) as you wish.

possible extension:
the user instead of just having the payment method "Bank transfer" could be offered several choices "Bank transfer Bank A", "Bank transfer Bank B", etc and only the corresponding details get displayed once selected. this would obviously be nicer but is currently not implemented.

In order to keep the administrator interface clean it would need a "Number of bank accounts:" field (default 1) and then an additional layer of collapsible fieldsets one for each bank containing fields as the current interface. Patch welcome.

Hi

Is it possible to enter two banks and make its display conditional to the billing country?
Ex: "Bank CH" for Swiss Customers, "Bank DE" for all others.

Maybe if there was a token available for each bank account it could be done with conditional actions?
I would chip in some money to support such an enhanchent.

I would still see the admin interface as outlined in post #1. On top we would need to find a way to make the conditional displaying happen (post #3) - but we should also allow to display all banks as in the original idea of this feature request.

I'll happily review and commit (when ready) such a patch.

Is it possible to enter two banks and make its display conditional to the billing country?
Ex: "Bank CH" for Swiss Customers, "Bank DE" for all others.

There is a cool module called uc_conditional_payment who does the conditional job.
http://drupal.org/project/uc_conditional_payment

But I still need multiple Bank Accounts,
as you outlined in post #1

I guess a work-around would be to simply duplicate your module.
But I would be cool, if we can make the multiple accounts visible and executable to the uc_conditional_payment module individually.

I think before the Bank Transfer Payment Module will be upgraded,
we should figure out how Conditional Payment detects the payment modules.
So each bank account could behave like a payment module and be processed by the Conditional Payment Module.

I also contacted the creator of uc_conditional_payment:
http://drupal.org/node/591006

Hopefully you both find a way to collaborate and get this two modules to work together!
As I need it, I am ready to sponsor it.

I hope we can get this working!

@yanku: as you are setting it back to active I assume you are going to provide the patch mentioned in #1?

well, I prepared a layout so far. see attached.

Are you interested to take an active role in developing the feature, or you want me to do the patch 100% as I have the impression?

I don't have the time to create a patch.

But I will review. Speaking of which, in your layout a few things need changing:
- the installation instructions still need to come first
- "Payment method title:" and the corresponding description below General settings can be dropped as now there is one for each bank
- "Payment method title:" and the corresponding description - you changed the text for both. please don't do that, this will create extra work for people translating the module
- and I don't think you need an "edit" button. just have the fieldset collapsible

further notes:
- make sure there is always at least one account - otherwise we probably run into strange behaviour
- make sure that people using the current version will not loose their settings when upgrading