$op = 'type' was unused in . Also feedapi_load_node() is never called, also not from the mapper.

CommentFileSizeAuthor
feedapi_cleanup.patch4.83 KBaron novak

Comments

alex_b’s picture

alex_b commented

$op = 'type' was unused in .

--where?

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented
Status: Needs review » Needs work

As long as we dropped automatic feed detection, it's really an unused thing. Maybe we want to extend this patch with dropping feed_type from {feedapi} schema. FeedAPI does not do any check about compatibility based of feed_type.
Two ways:
drop feed type entirely
add strict checkpoints what uses feed_type that returned by submodules.

aron novak’s picture

aron novak
Primary language Hungarian
Location Hungary, Budapest
commented

This is such a patch what I would like to see in FeedAPI 1.9.
I'd say to drop feed type entirely. The current development direction of FeedAPI indicates that, i think.