To allow for more granular theming of the JS-added links.

Comments

bdurbin’s picture

StatusFileSize
new533 bytes

Adding patch file.

robertdouglass’s picture

Status: Needs review » Needs work

That file just patches the .js file. I would have expected a change to the module that renders the block (to add the css class), and to the .css file as well. Can we think of a shorter class name?

bdurbin’s picture

Status: Needs work » Needs review
StatusFileSize
new527 bytes

Thanks for taking a look. Those "Show more / Show less" links are actually appended to the blocks on the client side when the page loads. They don't exist on the server when the blocks are rendered.

Are you suggesting that we refactor the blocks display code so that the links are generated at that time, and add the class there? I'd be happy to help explore that if that's the route you'd like to take. Not knowing the reasoning behind the current implementation, I do wonder if the links are added via JS to avoid something that was difficult to solve on the server.

Updated patch with shorter CSS class name.

pwolanin’s picture

I think you are right with this approach, since indeed this link will never exist without javascript being enabled.

robertdouglass’s picture

Status: Needs review » Fixed

Agree, now that I look at it in closer detail. Committed.

janusman’s picture

Status: Fixed » Reviewed & tested by the community

Simple enough, tested, works.

Resulting link:

<a class="apachesolr-showhide" href="#">Show more</a>
pwolanin’s picture

Status: Reviewed & tested by the community » Fixed
francewhoa’s picture

Confirming #3 works. Much easier to theme and design now. Thanks

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.