PDO uses inconsistant error codes between DBs [#505812]

The simpletest 'Invalid data' currently has one fail in Postgresql (and most likely sqlite too) because of this:

      // 23000 means "Integrity constraint violation" according to ANSI SQL.
      $this->assertEqual($e->errorInfo[0], '23000', t('Exception has proper SQLSTATE.'));

This error code is only returned from MySQL. PostgreSQL returns 23505 - "duplicate key value violates unique constraint", which is more accurate than what MySQL reports back. It would seem to me that were looking for error codes between in the 23000s is that how we want to patch this?

Comment	File	Size	Author
#3	505812-remove-ANSI-SQLSTATE-error-codes.patch	975 bytes	josh waihi

Comments

Comment #1

andypost

he/him

Russian

commented 30 June 2009 at 01:39

Suppose testing environment should know db type and use local code

Comment #2

andypost

he/him

Russian

commented 1 July 2009 at 11:49

Another trouble with that issue - this exception handler works inside simpletest's exception handler so sometimes (depends on php version and env config) bring unpredictable results, for example broke batch while returning exception after JSON data

Comment #3

josh waihi commented 5 July 2009 at 02:55

Status	File	Size
new	505812-remove-ANSI-SQLSTATE-error-codes.patch	975 bytes

The simple fact that databases will return different error codes means that this is an unreliable way to write code. It is not a condition Drupal can rely on due to its inconsistantcy between databases.

So lets just remove it and not encourage the use of it in code.