Fatal error after update to Drupal 6.13 (fixed in 6.x-1.5)

Jody Lynn - June 30, 2009 - 01:15
Project:Administration menu
Version:6.x-3.0-alpha3
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

PHP Fatal error: Only variables can be passed by reference in sites/all/modules/admin_menu/admin_menu.inc on line 536

I was getting WSOD on admin/build/modules and when changing themes.
I switched
system_clear_cache_submit($form_state, NULL) to
system_clear_cache_submit($form_state, $form_state)
and that fixed it.

#1

sun - July 1, 2009 - 19:30
Status:active» duplicate

That is already fixed in the latest development snapshot of 1.x. I'm not sure whether I will create a new release for this API change in Drupal core.

#2

AntoineSolutions - July 1, 2009 - 22:47

Sun,

I would ask you to reconsider rolling a new release since Drupal 6.13 has security fixes. Could you also post a link to the issue that this is a duplicate of? I could not find it. Thanks.

Cheers,

Antoine

#3

Alexander Ufimtsev - July 2, 2009 - 00:23

Yes, please roll a new release since it will break many sites using admin menu after upgrade to drupal 6.13. The only workaround I found was disabling admin_menu module with SQL statement, since simplest of operations return PHP Fatal error: Only variables can be passed by reference in sites/all/modules/admin_menu/admin_menu.inc on line 536:

mysql> update system set status='0' where filename='sites/all/modules/admin_menu/admin_menu.module';

#4

fenstrat - July 2, 2009 - 00:53

Same sittuation here.

Would be good to see a new release - also couldn't find the duplicate issue.

#5

Dave Reid - July 2, 2009 - 00:58
Status:duplicate» fixed

I'm just going to move this as fixed for now so others can find this issue until a release is out. The number of duplicates reported is annoying.

#6

Dave Reid - July 2, 2009 - 01:10

#7

Max Phillips - July 2, 2009 - 02:53
Status:fixed» needs work

I just updated and I'm getting this error everytime I try to go to modules!!!

#8

kim.pepper - July 2, 2009 - 02:58
Status:needs work» fixed

Thanks for the fix!

#9

kscheirer - July 2, 2009 - 02:58
Status:fixed» needs work

Installing admin_menu 6.x-1.x-dev did the trick, thanks!

considering how many sites are running this module (tons) and just upgraded to Drupal 6.13 (also tons), I would definitely recommend making a new release.

#10

Sborsody - July 2, 2009 - 05:19

Subscribing...

#11

Alexander Ufimtsev - July 2, 2009 - 10:59

Dave,

Drupal just 'got broken' for 20+ thousand installations that use Admin Menu v6.x-1.4. Are you really that surprised with the amount of duplicate bugreports?

A fix release would certainly help! :-)
A

#12

catch - July 2, 2009 - 11:40
Title:system_clear_cache_submit bug» Fatal error after 6.13 upgrade (fixed in 6.x-dev)

Retitling this.

#13

catch - July 2, 2009 - 11:52
Priority:normal» critical
Status:needs work» fixed

Marking back to fixed.

For reference this is is the commit to 1.x-dev where this was fixed -

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/admin_menu/...

#14

sun - July 2, 2009 - 12:22
Title:Fatal error after 6.13 upgrade (fixed in 6.x-dev)» Fatal error after update to Drupal 6.13 (fixed in 6.x-1.5)

1.5 out now.

Had to revert some bad German translations by hass first.

#15

ErwanF - July 2, 2009 - 13:20

Thanks for the release.

#16

ramones79 - July 2, 2009 - 13:25

Dave Reid: And the unhappy webmasters with non-working websites after the upgrade are annoyed as well - you may be assured of that.

#17

Dave Reid - July 2, 2009 - 13:31

@ramones79: I completely understand that this was frustrating for those of us that upgraded to 6.13. However, I'm just a co-maintainer so ultimately the decision to get a release out as quick as possible was up to tha_sun. We knew it was a problem, it was already fixed in the development build. We don't know when Drupal releases are going to happen exactly, so giving us maybe 24 hours to get an admin_menu release out would have been great.

And I meant annoying in the fact that people don't search for duplicate issues first, which is not a big deal. It's just something to live with on the d.org issue queues at this point.

#18

venusrising - July 2, 2009 - 13:31

Fatal Errors and White Screens
Not cool! Big waste of time trying to find out why Drupal 6.13 Upgrade was having problems only to find that this issue could have been avoided.

#19

mattys - July 2, 2009 - 14:12

after updating to alpha, i seem to be getting the below error, have also upload 6.13 drupal core, any ideas!?

user warning: Table 'fdeadrupaldb.cache_admin_menu' doesn't exist query: UPDATE cache_admin_menu SET data = '5a3b3367bb6a5a02c873eed6004fe6c8', created = 1246543982, expire = 0, headers = '', serialized = 0 WHERE cid = 'admin_menu:1:en' in /var/www/vhosts/fdea.co.uk/httpdocs/site/includes/cache.inc on line 109.
user warning: Table 'fdeadrupaldb.cache_admin_menu' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_admin_menu WHERE cid = 'admin_menu:1:en' in /var/www/vhosts/fdea.co.uk/httpdocs/site/includes/cache.inc on line 26.

#20

Dave Reid - July 2, 2009 - 14:16

@mattys: Try running update.php.

#21

mattys - July 2, 2009 - 14:17

Dave - thanks, just did that right after I left post, worked fine. Sorry for wasting time.

#22

ramones79 - July 9, 2009 - 22:46

As a matter of fact - I was able to successfully update to Drupal core 6.13
This time I followed the instructions in upgrade.txt strictly and - no problems at all.
I guess the new release was interfering with some of my already installed modules.
Following the instructions I disabled all external modules and this time I get it right.

I guess people /including myself/ should pay more attention to the user manuals etc.

But, on the other hand, I was able to upgrade from Drupal 6.11 to 6.12 without any problems and without following any guides. I just uploaded the new files, then ran the update.php and I was in the business already. So I guess it would be nice for the upgrade process to be simplified - so, to become more user friendly and painless.

#23

dwilliams5 - July 14, 2009 - 01:23

+1 I think a simplified upgrade process would be very beneficial, particularly for those more interested in content management and less interested in fiddling with php and website substructure issues.

#24

ramones79 - July 14, 2009 - 07:29

Absolutely. I'm sure that it's even possible to incorporate an automatic update to Drupal. When a new version of a module or the core itself is available - there appears a button UPDATE. You click on it and Drupal, through the server downloads the update from the appropriate internet place, then unpacks it and installs it. And there should be options hidden in the updated version (installer package) - they will control what is necessary to be temporarily disabled/enabled during the update, so it will perform smoothly and error-free.

I know this is only a conception and the reality is much more complicated, but I believe this is absolutely possible and one day it will be fact. I hope so :)

#25

Dave Reid - July 14, 2009 - 14:39

@ramones79, dwilliams5: Please take this conversation elsewhere. This is not related to admin_menu at all.

#26

System Message - July 28, 2009 - 14:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#27

hixster - September 29, 2009 - 15:58
Version:6.x-1.4» 6.x-3.0-alpha3

I'm getting this error,D6.v14 , tried all the latest versions of the admin module.

user warning: Table '******.cache_admin_menu' doesn't exist query: SELECT data, created, headers, expire, serialized FROM cache_admin_menu WHERE cid = 'admin_menu:1:en' in /Applications/MAMP/htdocs/*******/includes/cache.inc on line 26.

Pages aren't returning to previous page after action, having to click back button to return to previous page.

Also, when the module is activated, my block page is defaulting the the garland theme, not my choses theme (zen).

Any help much appreciated thanks.

Hix

#28

hixster - September 29, 2009 - 15:59

Update wasn't working , so I manually added the tables to the database and that seems to have fixed the issue.

 
 

Drupal is a registered trademark of Dries Buytaert.