MySQL error related to user module when viewing nodes

The problem is in the "WHERE r.rid IN ()" section since there should be something inside of the "()". Likely there should be a variable in there that is not getting populated for some reason.

what modules are you running? anything that affects access control?

Has this been fixed yet?

Private messaging is a pretty basic and much needed function for most community-oriented websites. This is going to make 4.7 completely unusable for at least five sites that I have to update.

I'm still getting these errors on 4.7 beta 5. So, no, I guess it hasn't been fixed yet. If I could I would :)

Its happening on my brand new DEV server running fresh copy of beta 5

drupal 4.7.0 beta 5

php 5
mysql 5
apache 2.x

I am guessing the developers are aware of this issue (I hope).

Hubert.

Two hours of debugging yesterday night produced a little more info on the problem. As Patrik Nelson mentioned, the bug is related to the Write to Author setting and occures during the execution of privatemsg_link. Also, the problem only appears when I'm logged in as $user->uid == 1 and viewing nodes with $node->uid != 1.

Best Regards,

Sören

It's happening to me no matter what uid I'm using. I've tried it with users with different permission levels also. Still doesn't work. Anyone have any further information on how to solve this?

I receive the same error only for uid 1 with 4.7.0 beta 6 on Xammp 1.5.1 under Windows XP. Right now this is the only non core module installed. Disabling it eliminates the problem.

the same problem occurs with the buddy module v 1.57 , disabling helps.

The problem is on line 19:

if (user_access('access private messages', $arg) && $arg->privatemsg_allow) {

Here is a quick fix that I think removes the error, although I'm not sure of the implications of this change:

if (!isset($arg->roles) || (user_access('access private messages', $arg) && $arg->privatemsg_allow)) {

PS: previewing this post did not show any preview - perhaps an error with drupal 4.7?

chrisken I think you've found the right spot - but I've fixed it another way. It looks like the node object is being passed to the user_access() function, and it isn't to happy about it. So I've added some code to load the author of the node, and the pass that to user _load.

My privatemsg_link function looks like:

function privatemsg_link($type, $arg) {
  if (user_access('access private messages') && ($type == 'node' || $type == 'comment') && variable_get("privatemsg_link_$type", 0) && (isset($GLOBALS['user']->privatemsg_allow) ? $GLOBALS['user']->privatemsg_allow : 1)) {
    $author = user_load(array(uid => $arg->uid));
    if (user_access('access private messages', $author) && $author->privatemsg_allow) {
      return array(l(t('write to author'), "privatemsg/msgto/$arg->uid"));
    }
  }
}

I'll put my two cents into this. I don't have any kind of private messaging modules installed and I get these errors when I call cron.

I started disabling modules to try to locate the source...

I found that I no longer get the errors when I disable the devel.module

Thanks jmiccolis --- that patch sorted it out nicely.

I changed the patch to the one in post #12 ...

... but now users can't see the menu item that tells them how many private messages they have. Although it does appear when admin is logged in.

Any ideas how I can get this menu item back?

Remove the line in privatemsg_menu() that says 'type'=>MENU_CALLBACK,

And it should work.

Oh, forgot, it's in the second menu item, around line 50

Sorry to be thick here, but which line should I comment out?

function privatemsg_menu($may_cache) {
  $items = array();
  global $user;

  if ($may_cache) {
    $items[] = array('path' => 'admin/settings/privatemsg',
        'title' => 'privatemsg',
        'callback' => 'privatemsg_configure');
  }
  else {
    $items[] = array('path' => 'privatemsg',
                     'title' => t('view inbox') . ' ('. (int)_privatemsg_get_new_messages() .')',
                     'callback' => 'privatemsg_page',
                     'access' => user_access('access private messages'),
                     'type' => (isset($user->privatemsg_allow) ? $user->privatemsg_allow : 1) ? MENU_DYNAMIC_ITEM : MENU_CALLBACK);
  }
  return $items;
}

I removed

,
                    'type' => (isset($user->privatemsg_allow) ? $user->privatemsg_allow : 1) ? MENU_DYNAMIC_ITEM : MENU_CALLBACK)

but my users still can't see the menu item :(

I am getting this same errors in my 4.7 RC3, with no additional modules installed or configured (just core), when I navigate to:
administer -> comments -> configure tab

warning: array_keys(): The first argument should be an array in /myhome/me/public_html/gates-chili-high/modules/user.module on line 348.

warning: implode(): Bad arguments. in /myhome/me/public_html/gates-chili-high/modules/user.module on line 348.

user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT DISTINCT(p.perm) FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN () in /myhome/me/public_html/gates-chili-high/includes/database.mysql.inc on line 120.

I tried the fix suggested in #13 and this removed all the error messages from the front page. But now when I click on the username I get: warning: Attempt to assign property of non-object in D:\xampp\ost47\modules\privatemsg\privatemsg.module on line 264. The message function seems to work though.

I think the problem is that the handlng of roles in 4.7 has changed. in 4.7 users always have the "authenticated user" role, but it isn't saved in the database anymore. So you cannot assume that a user without $user->roles has no roles at all.

Had the "p" "p" error and applied the patch. It worked but then I now receive the user.module error on line 348.

I see many many others have had this same problem for months. Is Privatemsg obsolete? Is there another module that does that same thing privatemsg does but w/o the errors? Tried both the 4.7 and cvs modules with and w/o patches. Nothing works and I kinda need this module. (maybe I should have stuck with 4.6)

Any help is appreciated.

see if modifying user.module helps as a workaround....i had nearly identical error messages under different circumstances...

see
http://drupal.org/node/63375

Just adding myself to the discussion for tracking. I'll happily do my best to help validate any patches.

Please see fix/patch here.