As hook_init() is only called for not cached pages, it would be better to use nodewords_preprocess_page(), which would be called for each served pages.

Comments

jamesoakley’s picture

jamesoakley
Primary language English
Location North Yorkshire, UK
commented

I'll subscribe to this issue, seeing as I was the person who requested that this issue be addressed in 6.x-1.x as well.

The background to this issue can be found at http://drupal.org/node/439234.

asak’s picture

asak commented

Yep, this is a real issue.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Fixed

The code has been changed.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue tags: +6.x-1.0
Island Usurper’s picture

Island Usurper commented
Version: 6.x-1.x-dev »
Status: Fixed » Active

I've set the other issue to 6.x-1.x since that's where the patch is. This issue can be for 6.x-2.x since it uses such a different model to construct the meta tags. It still shouldn't use hook_init() to build them, though, since modules that load their include files then may not have had a chance yet.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: » 6.x-1.x-dev
Status: Active » Fixed

As there is already a reference to this issue report in CHANGELOG.txt, it is better to keep this report for version 6.x-1.x-dev.

Status: Fixed » Closed (fixed)
Issue tags: -6.x-1.0

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +6.x-1.0

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.