Should promote the proper use of the Drupal APIs by using module_load_include() instead of include_once drupal_get_path('module', 'comment') .'/comment.admin.inc';, especially since module_load_include checks to see if the file has already been included and can skip the include_once call.

CommentFileSizeAuthor
#2 506568-module-load-include.patch837 bytesdave reid
#1 506568-module-load-include.patch698 bytesdave reid

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Needs review
StatusFileSize
new 506568-module-load-include.patch698 bytes

Ok, so I double checked and module_load_include() doesn't check to see if the file has already been included, but you never know, at some point that might be added. Still feels good to use the proper APIs.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
StatusFileSize
new 506568-module-load-include.patch837 bytes

Fixing offset.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed to CVS using a revised module_load_include('inc', 'comment', 'comment.admin');

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.