I know it may not be the problem of the filefield_insert,because the filefiled only affects when the node is submitted,so the file name that filefield_insert get has changed when the node is submitted if using the filefield_paths's filename rewrite feature.
May be the filefield_paths should affacts when the file is uploade but not the node is submitted.
I just want to konw how other guys think..

CommentFileSizeAuthor
#3 filefield_insert.tar_.gz11.8 KBweynhamz

Comments

quicksketch’s picture

quicksketch
he/him
commented
Title: it will get the wrong file name where use with filefield_path.. » Images use the wrong path when placed in the body
Project: FileField Insert » File (Field) Paths

FileField Insert does not work when combined with FileField Paths, this is true. Unfortunately there's no simple way to make this work either (that's why FileField Paths is a separate module, because it creates so many edge-cases). This problem would exist even if you weren't using FileField Insert and trying to manually type in the IMG tag. It's a general problem with FileField Paths and should be handled by that module.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Actually, it should.
A feature was introduced in one of the earliest builds of FileField Paths that has been tweaked a few times that searches the body and teaser variables for un-processed file paths and converts them to the new paths.

If this is not happening then something is definitely wrong.
Let me know what version of FileField Paths you are using and any other information so I can attempt to reproduce the issue.

Cheers,
Deciphered.

weynhamz’s picture

weynhamz
Location Ningbo
commented
StatusFileSize
new filefield_insert.tar_.gz11.8 KB

Thank you for your quickly response,it's nice to see the filefield_paths's maintainer to focus on this problem,I use the newest release 6.x-1.2.And I use filefield_paths to customise the file the upload path and it's filename.The change of the path doesn't matter,but the change of fliename will cause a link break ...
And I use the the pacth for filefield_insert to intergrate the cck formats.At the time I create a new node and use the filefield_insert to insert one formats to the text body e.g. a image_cached image link to the origianl image using lightbox effect,and then press the submitted button,nothing could be seen.The img tag's source is the old filename of the image,but in the server file system it use the new name.
And before submitted,I've checked the database's files table and the filesystem,it still the old one,but once submitted,all of these will change.
May be it's nice to change the filename after the file uploading just have finished to avoid the file name conflict.
And I use the public downloading feature.
Hope all the above is usefull,and sorry for my poor english,there must be lots of mistakes,haha,I am a chinese user,sorry.
Hope Filefield Paths can work with with Filefield Insert perfectly,all of these two modules are excellent.
At last ,I attach my patched FilefieldInsert package.may be it is necessary.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

At this stage I am assuming that the issue is related to the patch. I'm not saying it's the cause of the issue, but I'm guessing it's preventing the FileField Paths functionality for updating the unprocessed file location in the body.

I say guess because the patched version you provided me just breaks FileField Insert completely, so I will have to look into it further.
I can confirm that FileField Insert without the patch and FileField Paths 1.2 work perfectly together, even if quicksketch doesn't believe so :)

Cheers,
Deciphered.

weynhamz’s picture

weynhamz
Location Ningbo
commented

Hope can it can be solved some future days.quicksketch is being working for intergrating cck formats,may be it can be solved when the offical release with cck formats intergrating.Thank you,Deciphered.

quicksketch’s picture

quicksketch
he/him
commented
Project: File (Field) Paths » FileField Insert
Category: bug » feature

I can confirm that FileField Insert without the patch and FileField Paths 1.2 work perfectly together, even if quicksketch doesn't believe so

Hey! Well that's not fair, I didn't know techlive was using the CCK formatters patch on top of FileField Insert. If that's the case, then I don't doubt they don't work together. Because as noted in that patch, some properties are not yet available when formatters are executed. Thanks for your input Deciphered, I'll move this back to the FileField Insert queue and keep it on radar for #479310: Add support for add'l CCK Formatters (Lightbox2, etc.) patch.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

quicksketch,

Currently FileField Paths replaces references of the unprocessed file path in the body field using a simple regular expression, so when the patch is finished there will definitely be an issue.

I'll try to make some time to look further into this.

weynhamz’s picture

weynhamz
Location Ningbo
commented

It's still not working if i use the original filefield_insert package not the patched ,it still use the original filename not the changed name by filefield paths.May be Deciphered should check this.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

@techlive

When you say it uses the original filename, do you mean before you save the node? Because it won't be changed until you save the node.

If it isn't changing after you save the node, you may have an issue, but as I stated above, I tested the functionality and it worked perfectly for me, so please provide as much information you can on how to reproduce the issue, including what versions of modules you are using, and I'll see if I can help.

Cheers,
Deciphered.

luckysmack’s picture

luckysmack commented

Im also having the same issue. I am using FileField Insert 6.x-1.x-dev and FileField Paths 6.x-1.3 (should i switch back to 1.2 if it works there?).
Using the filefield paths module i set upload paths to the current location:

uploads/[type]/node-[nid]/[yyyy]/[mm]-[dd]

I have also entered the same path on the nodes edit page under path settings, in workflow settings as well as the cck imagefield's upload path settings. i upload an image with imagefield, select an imagecache preset, and select "insert into body" with 2 different preset sizes and into 2 different places in the text. The follwoing paths are given (in this order):

/sites/default/files/imagecache/img-120x-square-thumbnail/spam.jpg"
/sites/default/files/imagecache/img-80x-square-mini/spam.jpg

i then, at the bottom of the node insert the original image. after saving the node only the original node saves and the imagecahced preset does not show. browsing to the directory of: "/sites/default/files/imagecache/img-120x-square-thumbnail/spam.jpg" there is no image saved there, hence the non working image (same for both imagecache preset paths). but if i browse to the location "/sites/default/files/imagefield_thumbs/uploads/blog_entry/node-116/2009/07-28" the "spam.jpg" file is present with a resolution of 80x80 pixels. the 120x is not present. I assume drupal saved both here and the 80x image over wrote the 120x image. The original image is in its proper location at "/sites/default/files/uploads/blog_entry/node-116/2009/07-28" .

So the paths that imagefield_insert are not the proper paths to the imagecached images. I would love to use both together, until this is fixed would the easiest solution be to disable fielfield_insert so i can still use paths? The site is not currently live but am hoping it will be soon. If i dont go live with the insert function it wont be detrimental, just a nice feature to have. Also, along with using both of these together on the same node i receive the following error printed onto the screen:

    * warning: Division by zero in /var/www/drupal-files/sites/all/modules/imageapi/imageapi.module on line 221.
    * ImageMagick reported an error: convert: unable to open image `uploads/blog_entry/node-116/2009/07-28/spam.jpg': No such file or directory @ magick/blob.c/OpenBlob/2418. convert: missing an image filename `sites/default/files/imagecache/img-120x-thumbnail/uploads/blog_entry/node-116/2009/07-28/spam.jpg' @ wand/convert.c/ConvertImageCommand/2710.
    * warning: Division by zero in /var/www/drupal-files/sites/all/modules/imageapi/imageapi.module on line 190.
    * warning: Division by zero in /var/www/drupal-files/sites/all/modules/imageapi/imageapi.module on line 190.
    * warning: Division by zero in /var/www/drupal-files/sites/all/modules/imageapi/imageapi.module on line 330.
    * ImageMagick reported an error: convert: unable to open image `uploads/blog_entry/node-116/2009/07-28/spam.jpg': No such file or directory @ magick/blob.c/OpenBlob/2418. convert: missing an image filename `sites/default/files/imagecache/img-80x-square-mini/uploads/blog_entry/node-116/2009/07-28/spam.jpg' @ wand/convert.c/ConvertImageCommand/2710.

I hope the information i provided is useful. I have not patched either of the paths or insert modules. So if there is a temporary patch then im all for it, but havent seen one. Also I was wondering that if I replace my filefield_paths from 1.3 back to 1.2 will that make them work together? Any help will be greatly appreciated, thanks.

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Closed (fixed)

I'm closing this issue because it's not an issue with FileField Insert, but with FileField Paths. If FileField Insert is inserting the image, that's where it's job ends.