Customizable titles everywhere using tokens

Posted by Todd Nienkerk on June 30, 2009 at 9:37pm

Issue Summary

It would be useful to allow customization of the talk page's title in the UI. In order to allow the node title to appear in this custom title, tokens would need to be enabled.

Currently, the page title is hard-coded. Here's 6.x-1.5:

drupal_set_title(check_plain($node->title));

And 6.x-1.x-dev as of June 25, 2009:

  drupal_set_title(t('@title page for @node', array('@title' => talk_title(), '@node' => $node->title)));

Comments

#1

Posted by Todd Nienkerk on June 30, 2009 at 9:38pm

Title:

Customizable title page using tokens

» Customizable page title using tokens

#2

Posted by greggles on July 6, 2009 at 1:51am

Title:	Customizable page title using tokens	» Customizable titles everywhere using tokens
Status:	active	» needs review

And a patch...to provide this.

I actually decided to provide 3 different settings:

1. For the title of the talk page
2. For the "link" on the "links" area of a node which can be left blank to disable it
3. For the Tab that shows up next to "View" and "Edit"

I created an update function that creates the three values and defaults them to the value from the one that was previously customizable. It also gives a hint to the user that they should configure further.

Attachment	Size	Status	Test result	Operations
506658_customizable_text_tokens.patch	5.52 KB	Ignored: Check issue status.	None	None

#3

Posted by cwgordon7 on July 7, 2009 at 2:02pm

Status:

needs review

» needs work

Coding standards, * Optional node object. needs to be further indented.

#4

Posted by GregoryHeller on July 10, 2009 at 9:20pm

I hope to take a look at this patch soon! will let you know what i think of the functionality when i have.

#5

Posted by greggles on July 14, 2009 at 5:20pm

Status:

needs work

» needs review

Here's a re-rolled patch.

@GregoryHeller, that would be great. I've also posted a screenshot.

Attachment	Size	Status	Test result	Operations
506658_customizable_titles_tokens_5.patch	5.17 KB	Ignored: Check issue status.	None	None
talk_settings_token.jpg	33.5 KB	Ignored: Check issue status.	None	None

#6

Posted by greggles on July 14, 2009 at 5:21pm

I also committed #511026: provide token for number of comments on a node to token module which is really useful in this area... I can roll a token release to coincide with the next talk release so we have good support here.