Customizable titles everywhere using tokens

Todd Nienkerk - June 30, 2009 - 21:37
Project:Talk
Version:6.x-1.x-dev
Component:User interface
Category:feature request
Priority:normal
Assigned:greggles
Status:closed
Description

It would be useful to allow customization of the talk page's title in the UI. In order to allow the node title to appear in this custom title, tokens would need to be enabled.

Currently, the page title is hard-coded. Here's 6.x-1.5:

  drupal_set_title(check_plain($node->title));

And 6.x-1.x-dev as of June 25, 2009:

  drupal_set_title(t('@title page for @node', array('@title' => talk_title(), '@node' => $node->title)));

#1

Todd Nienkerk - June 30, 2009 - 21:38
Title:Customizable title page using tokens» Customizable page title using tokens

#2

greggles - July 6, 2009 - 01:51
Title:Customizable page title using tokens» Customizable titles everywhere using tokens
Status:active» needs review

And a patch...to provide this.

I actually decided to provide 3 different settings:

1. For the title of the talk page
2. For the "link" on the "links" area of a node which can be left blank to disable it
3. For the Tab that shows up next to "View" and "Edit"

I created an update function that creates the three values and defaults them to the value from the one that was previously customizable. It also gives a hint to the user that they should configure further.

AttachmentSize
506658_customizable_text_tokens.patch 5.52 KB

#3

cwgordon7 - July 7, 2009 - 14:02
Status:needs review» needs work

Coding standards, * Optional node object. needs to be further indented.

#4

GregoryHeller - July 10, 2009 - 21:20

I hope to take a look at this patch soon! will let you know what i think of the functionality when i have.

#5

greggles - July 14, 2009 - 17:20
Status:needs work» needs review

Here's a re-rolled patch.

@GregoryHeller, that would be great. I've also posted a screenshot.

AttachmentSize
506658_customizable_titles_tokens_5.patch 5.17 KB
talk_settings_token.jpg 33.5 KB

#6

greggles - July 14, 2009 - 17:21

I also committed #511026: provide token for number of comments on a node to token module which is really useful in this area... I can roll a token release to coincide with the next talk release so we have good support here.

#7

greggles - July 15, 2009 - 00:00

#8

greggles - July 15, 2009 - 22:22
Status:needs review» fixed

Committed to the 6.x-1.x branch: http://drupal.org/cvs?commit=238066

I also provided more guidance in the README.txt for the way to use this feature.

#9

System Message - July 29, 2009 - 22:30
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.