There are several threads around stating that MyISAM is not a good choice for high-traffic sites and InnoDB is better. I was wondering why we hard-code the value at MyISAM and not let MySQL just choose based on its configured settings and no one in #drupal was able to tell me, so here is a patch which does this.

CommentFileSizeAuthor
#9 no-myisam.patch2.2 KBwebchick
#6 database.mysql_13.patch10.76 KBwebchick
database.mysql_12.patch10.54 KBwebchick

Comments

drewish’s picture

drewish commented

+1 on this patch and making the change part of the coding standards.

killes@www.drop.org’s picture

killes@www.drop.org commented

+1

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs review » Reviewed & tested by the community

Ok then... Setting this RTBC.

Also, an excerpt from http://dev.mysql.com/doc/refman/5.0/en/storage-engines.html to support this change:

"If you omit the ENGINE or TYPE option, the default storage engine is used. Normally, this is MyISAM, but you can change it by using the --default-storage-engine or --default-table-type server startup option, or by setting the storage_engine or table_type system variable."

pfaocle’s picture

pfaocle
He/Him
Primary language English
commented

+1

Seems sensible to me. Perhaps we need a mention of this in INSTALL.mysql.txt too?

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Needs work

Wanted to apply it, but doesn't apply anymore.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
StatusFileSize
new database.mysql_13.patch10.76 KB

Oops! Let's try this. :)

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Reviewed & tested by the community
killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new no-myisam.patch2.2 KB

Crap. Forgot about updates.inc too. Sorry. ;(

killes@www.drop.org’s picture

killes@www.drop.org commented
Status: Reviewed & tested by the community » Fixed

applied, had to edit a bit.

markus_petrux’s picture

markus_petrux commented

It doesn't worth to open a new issue, if I'm mistaken...

Looking at the changes made by this patch I figured that in updates.inc there are newly created tables that are defined with the UTF8 stuff (example: system_update_173), but some others don't (example: see system_update_166). Is that correct?

markus_petrux’s picture

markus_petrux commented

Nevermind, system_update_169 does the job for previously created tables. sorry. :-?

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)