problem with empty infowindow - bug
teszek - July 1, 2009 - 12:10
| Project: | GMap Module |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
in marker.js is:
if (marker.text) {
if think this is bug and should be instead:
if (marker.text.length > 30) {
because marker.text always exist and has:
<div class="gmap-popup"></div>
#1
is always empty because it's reading the wrong variable.
Code from the gmap.module:
<?php// Add a class around map bubble contents.
// @@@ Bdragon sez: Becw, this doesn't belong here. Theming needs to get fixed instead..
if (isset($map['markers'])) {
foreach ($map['markers'] as $i => $marker) {
// Added in DPM from devel module
dpm(array("MARKER $i" => $marker));
$map['markers'][$i]['text'] = '<div class="gmap-popup">' . $marker['text'] . </div>;
}
}
?>
You'll notice from the dpm() that $marker['text'] is blank and those gmap-popup is always blank.
@bdragon: from reading your comments in the code, I can tell you know this stuff is horribly broken. Could we at least get a simple patch to fix up the theming layer of the gmaps module to reflect the documentation in THEMEING.txt, it wouldn't be much work and would help the 5000+ people who are using RC1.
I am very surprised to not find a lot of issues on this bug though. I assume most people are using the views integration which works fairly well.