Posted by thenorman on July 1, 2009 at 2:42pm
| Project: | Ubercart |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | thenorman |
| Status: | closed (fixed) |
Issue Summary
This is a patch for the UC_ORDER Module to force eall compliance.
Note: During the process of EALL updating the code, I found that fixing a some portions of the code causes unnoticed, undesired results down the execution pipeline. The changes made in this file are minimal and have been tested on the newest branch of ubercart. This may break modules that are dependent on the exact output of the broken modules.
Comments
#1
#2
Tagging
#3
#4
This issue was submitted long before I became an Ubercart maintainer.
I went through the patch line-by-line and found that most of these changes have already been made in the Ubercart code. Some of the changes in the patch were code style changes only, and some of the changes were wrong - there was a misspelled variable, and a variable which was improperly renamed, and a few other minor flaws. The remaining changes that have not yet been addressed I changed by hand and committed.
I'm not positive that I've fixed *all* the E_ALL errors in the uc_order module, but if there are any left feel free to open a new issue with the details of where and when the error shows up.
Note that this issue has never had a review, which presumably would have found the flaws. So if anyone is disappointed that it took so long for this to be addressed, be thankful that it wasn't just blindly committed because then there would have been real errors to contend with, not just PHP notices. You can help to make fixes more timely by reviewing proposed patches like this one and providing feedback as to whether they work or not.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.