Posted by Amitaibu on July 1, 2009 at 8:40pm
Jump to:
| Project: | BitTorrent |
| Version: | 6.x-9.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | overall |
| Status: | closed (fixed) |
Issue Summary
Instead user is asked to copy announce.php to root (or create symlink).
I guess, from looking in the code, is that bittorent is trying to avoid a full drupal bootstarp. However I think it comes with a price of usability, flexibility and code readability.
If we would declare announce as a menu item:
1) No need to ask users to copy files to root.
2) Users can menu_alter() and define their own access.
3) No 'hacks' to load portions of drupal which are not intiaizlied.
Comments
#1
I agree it would be easier, but i also know that medium to large scale trackers need this "hackish" way to keep the tracker viable and useable.
So maybe as a compromise there could be an included menu_alter() boot as well for smaller site or for testing purposes. If this was done i think it would be wise to also include a switch in the admin to toggle the menu item access. Then there is no way for people to use it when the more efficient method is in use.
Thoughts?
#2
> but i also know that medium to large scale trackers need this "hackish" way to keep the tracker viable and useable.
Can you please give more information about it? There are many parts in Drupal that should work fast - does torrent really require the partial bootstrap? would be interesting to have some benchmark tests ;)
#3
I will try to put together some more information. I agree it would be interesting to see some benchmarks as well.
I hope we conclude that the "hackish" way is not needed ^_^
#4
I thought about this earlier, and came to following result: we need to implement both and use menu as default.
P.S. If you need this asap, I cannot help you, because I'm busy these days.
#5
#6
#7
Automatically closed -- issue fixed for 2 weeks with no activity.