Following #506966: Remove $op from hook_ec_transactionapi(), we should remove $op from hook_product() and implement individual hooks in the form hook_ec_product_[op]().

Comments

gordon’s picture

gordon commented

Actually I want to mark the productapi as depreciated and remove it in the major version, in favor of product features.

So changing a depreciated api I think is a waste of time. I would prefer people port modules to the product features api and then it will be easier to drop the productapi later.

Gordon.

recidive’s picture

recidive commented

Yes, just after I submit this issue I saw the new product features api, I'll help documment this, but in turn I'd like to see the old productapi removed.

I'll submit a patch as soon as #508126: Remove hook_product_transaction for simplicity get commited. Or maybe the other issue can be made a duplicate of this one.

I can help with porting other modules as well.

recidive’s picture

recidive commented
Status: Active » Postponed

As noted by Gordon, this one is postponed.