Hi!

Just tested this module from CVS. Very useful.

Found one little problem. The commentmail_opts option is not saved/used properly. The problem is in 2 different places:

1) In commentmail_settings():

  $form['commentmail_opt'] = array(

Should probably be:

  $form['commentmail_opts'] = array(

2) In commentmail_comment():

      $opt = variable_get('comment_opts', 'approval');

Should probably be:

      $opt = variable_get('commentmail_opts', 'approval');
CommentFileSizeAuthor
#2 commentmail.module5.98 KBchrishathaway

Comments

phillipadsmith’s picture

Thanks -- that seemed to work nicely (and fix the issue).

Phillip.

chrishathaway’s picture

StatusFileSize
new5.98 KB

Here's the module file with the fix (until someone decides to update the CVS)

markus_petrux’s picture

I believe it can only be done by the module owner/maintainer... or (s)he could grant permission to commit to someone else.

PS: I added a similar feature to the Akismet module (notify content admins/moderators when new content is posted, only when spam is detected or nothing at all).

salvis’s picture

It's fixed in the current default release (HEAD, 13/11/2006 - 00:24, 8.39 KB).

jjeff’s picture

Status: Active » Fixed

Yes. I believe this is fixed.

Anonymous’s picture

Status: Fixed » Closed (fixed)