While debugging PIFRv2, gordonh ran across a problem where the simpletests were failing because the URL for testing the checkout was too long, http://drupaltesting.heydon.com.au/sites/drupaltesting.heydon.com.au/fil.... That resulted in the following error:

OPML Remote URL cannot be longer than 128 characters but is currently 135 characters long.

The remote field doesn't have a maxlength on it, so setting one might get rid of the problem, especially in cases where the remote URL has a combination of access key hashes for private access.

CommentFileSizeAuthor
#3 508280-remote-opml.patch571 bytesgordon
#1 508280_lengthen_opml_remote_url.patch711 bytesdeekayen

Comments

deekayen’s picture

deekayen commented
Status: Active » Needs review
StatusFileSize
new 508280_lengthen_opml_remote_url.patch711 bytes

This patch takes the remote field from an undefined maxlength that appears to default to 128 to 1024. I picked 1024 based on the limits of HTML 3 specs, and old versions of IE3 and Opera for GET limits.

gordon’s picture

gordon commented

I was thinking about this one this morning and really the remote field should not have any limit.

Having a limit of 1024 is good, but it looks kludgy.

gordon’s picture

gordon commented
StatusFileSize
new 508280-remote-opml.patch571 bytes

Here is a new patch which disables the maximum length for this field.

Basically it explicitly sets the #maxlength to NULL so the maxlength attribute on the input field is not set at all.

deekayen’s picture

deekayen commented

I agree with #3, but I think there are limitations beyond our control like 2083 characters in IE.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.