I would like to be able to theme the display of the file download page shown to users in uc_file module.

This patch just moves things around to separate the logic from the output so all the output can go in a theme function.

CommentFileSizeAuthor
ubercart_uc_file.patch5.66 KBunivate

Comments

torgospizza’s picture

torgospizza
he/him
Primary language English
Location Portland, OR
commented

+1

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed

Hooray for more theme functions.

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

tr’s picture

tr commented
Status: Closed (fixed) » Needs work

This patch broke the tablesort. See #746450: uc_file.pages.inc,v 1.1.2.17 invalid argument for foreach() in tablesort.inc - the $header array is needed by tablesort_sql(), and can't just be moved into a theme function.

I like the idea of a theme function here - can you re-do the patch to make it work?

univate’s picture

univate commented
Status: Needs work » Needs review

It looks like that patch posted on that issue should fix that bug:
http://drupal.org/node/746450#comment-2764640

I haven't tested it but the code looks correct.

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed

#746450: uc_file.pages.inc,v 1.1.2.17 invalid argument for foreach() in tablesort.inc was committed, so this should be good now.

Status: Fixed » Closed (fixed)
Issue tags: -theme layer

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +theme layer

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.