.

CommentFileSizeAuthor
db_placeholders_rip.patch1.21 KBcatch

Comments

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
Crell’s picture

Crell commented
Status: Needs review » Reviewed & tested by the community

I think it is appropriate that catch get to do the honors, given the work he put in to make it obsolete. :-)

Yay!

damien tournoud’s picture

damien tournoud commented

Yay!

dries’s picture

dries commented
Status: Reviewed & tested by the community » Needs work

Yay, Sir!

Committed to CVS HEAD. Marking 'code needs work' until the drupal.org upgrade documentation has been updated.

Crell’s picture

Crell commented
Status: Needs work » Fixed

There's already an item in the upgrade docs for "the entire database layer has been rewritten, here's the handbook pages for it". I don't think we need to separately mention each function that is removed or added.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

hadsie’s picture

hadsie commented
Component: database system » documentation
Status: Closed (fixed) » Active

I wasn't able to find any docs on how to replace db_placeholders when upgrading from D6 -> D7. I'm assuming we replace it using the :myvariable type of syntax. But should there be documentation on the 6 -> 7 upgrade guide (http://drupal.org/node/224333) ?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Fixed

You can simply use an array and it will work. See chapter "Placeholder arrays" at http://drupal.org/node/310072. I've extended the basic example in the upgrade docs to cover this case but note that not every change of the new DB API can be documented there, there are simply too many.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.