I am impressed with Storm module, but I would like to make a request.

Could someone make a patch that shows "Person/People" column in Tasks?
Also if another can be made, I would like to see "Project Manager" column show in Projects.
That will be great.

PS:Sorry, I am duplicating my requests in different places because I am new to this site.

Comments

homoludens’s picture

basically it is adding new field "Project Manager" to "Storm Project" and adding "Person" to "Storm Task" - and consequently to displayed list?
sounds like nice feature - one could easily find person responsible for specific project and task.

just give me confirmation that i have understood you right, and i will try to make it relatively soon.

what do others think of this?

Magnity’s picture

If this is to be commited, I think it should be done in conjunction with with #380008: Development of Storm Teammember, if not, then fine.

Kamikaze’s picture

Homoloudens,
You understood it right. Thanks for working on it.

Kamikaze’s picture

So, have there been any pregress on this?
Just checking.

homoludens’s picture

Not sure if we will do it like that right now. Please take a look at discussion #380008: Development of Storm Teammember. We are brainstorming new features of teammember module and it's connection with others modules. I have, already, included your suggestion as idea, but your input can be valuable.

Problem is much bigger then just assigning people to project/tasks.
That does not mean that i wont add those columns before redesign, but i must wait a little to think about it.

homoludens’s picture

StatusFileSize
new9.86 KB

here is patch that adds person to tasks. it is against latest dev (2009-Jul-07).

before you try it you will have to execute this two sql commands:

ALTER TABLE stormtask ADD person_organization_nid INT;
ALTER TABLE stormtask ADD person_nid INT;

try and report.

EDIT: added _nid for name of new table columns.

bamakojeff’s picture

Status: Active » Needs review

Thanks for the patch. I just applied it to stormtask 6.x-1.23 and the following part failed.

---------------------------------------------------------
diff -Naur stormtaskOrig/stormtask.module stormtask/stormtask.module
--- stormtaskOrig/stormtask.module 2009-07-07 01:04:15.000000000 +0200
+++ stormtask/stormtask.module 2009-07-08 17:38:07.000000000 +0200

@@ -479,7 +597,7 @@

function stormtask_form_alter(&$form, $form_state, $form_id) {
- if (module_exists('date_api')) {
+ if (module_exists('date_api') && module_exists('date_popup')) {
if ('stormtask_node_form' == $form_id) {
$node = $form['#node'];
$form['group4']['datebegin'] = array(
-----------------------------------------------------------------------

There's no "function stormtask_form_alter" anywhere in the stormtask module files.

homoludens’s picture

it is patch against -dev. But even if you use -dev simple patching would not work - it is better to edit those changes by hand, because there are a lot of changes in storm task in last few weeks so some lines are moved - so it is hard to make patch.

on the other side you can edit stormtask_add_person_diff_dev.patch file and delete following part, since it is not needed for this patch, and try again:

@@ -479,7 +597,7 @@
 
 
 function stormtask_form_alter(&$form, $form_state, $form_id) {
-  if (module_exists('date_api')) {
+  if (module_exists('date_api') && module_exists('date_popup')) {
     if ('stormtask_node_form' == $form_id) {
 	$node = $form['#node'];
 	$form['group4']['datebegin'] = array(
bamakojeff’s picture

Thanks for the clarification. I also had to slightly change the mysql commands that needed to be run. The stormtask.module refers to columns "person_nid" and "person_organization_nid" rather than just "person_organization" and "person".

ALTER TABLE stormtask ADD person_organization_nid; INT;
ALTER TABLE stormtask ADD person_nid INT;

Thanks again for the patch. :-)

homoludens’s picture

Thank you for correction. Glad you find it useful.

bamakojeff’s picture

StatusFileSize
new10.75 KB

If it helps anyone, here's a patch against v.1.23 that allows you to assign a person to a task. I just made a few changes so it worked with this branch and themed the new sections like everything else.

Thanks again for all the work on the Storm module and for taking the time to write this patch so we can assign someone to each task. It makes our life easier. :-)

Magnity’s picture

Status: Needs review » Closed (duplicate)