Links at bottom of node cover blocks

bigmack83 - July 3, 2009 - 10:39
Project:Admin:hover
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:conortm
Status:active
Description

when viewing a node, the links at the bottom of the page, the bar covers the blocks on the right side of the page. Image attached. Also prevents from clicking links in the blocks near the issue.

AttachmentSize
Screenshot.png12.56 KB

#1

bigmack83 - July 3, 2009 - 11:09
Project:Black Mamba» Admin:hover
Version:6.x-1.0» 6.x-1.x-dev

I have noticed that this issue is with the admin_hover module, when disabling the module the problem does not occur. I did use firebug briefly to try and figure out what was causing the issue but did not find the problem. Im still limited on my css knowledge but if i find an answer i will post it as I do like the module.

#2

conortm - July 7, 2009 - 19:22
Assigned to:Anonymous» conortm
Status:active» postponed (maintainer needs more info)

bigmack83,

thanks for reporting this! is the theme you are using contributed or custom? if contributed, I'll install it and take a look. if it's custom, however, i'm not sure how much help i can be without seeing the code and the theme in action... I have a feeling that the theme is having an issue with the "relative" positioning of a node that has admin_hover links, but I'm not positive.

sorry i can't be of more assistance, but please provide some more info, and i'll try my best to get this resolved.

thanks!

#3

bigmack83 - July 8, 2009 - 12:41

I am running the theme black mamba which is a variation of the acquia marina theme. I am also running this on another drupal instance on my laptop using the garland theme and i have not noticed the same issue. not sure how that will help.

http://drupal.org/project/black_mamba
http://drupal.org/project/acquia_marina

*EDIT: i did notice the same issue in the acquia_marina theme as well

#4

conortm - July 13, 2009 - 17:27
Status:postponed (maintainer needs more info)» active

bigmack83,

thanks, i will look into this further and update with my findings. thanks for reporting this, and for your patience!

~conor

#5

bigmack83 - July 14, 2009 - 00:53

Awesome, thanks. The site wont be live for a bit, so no worries.

#6

Digital Deployment - August 22, 2009 - 18:17

Would it be possible to prepend the admin:hovers to the node and use position:absolute instead of appending them (putting them after the node) which therefore requires position:relative to get them back up to the top? This would eliminate the funkiness where the position:relative div covers anything floated right in Firefox or Safari. (e.g. blocks in certain themes.)

line 3:
.has-admin_hover {
position:relative;
}

#7

Digital Deployment - August 22, 2009 - 19:54

Here's how I fixed the problem: (although the hovers now show left aligned instead of right aligned, I could add margin-left: 400px; to .admin_hover to roughly simulate the same effect.) Seems to work cross-browser...

- Used prepend instead of append (see patch below)
- Removed the position:relative

--- admin_hover.js (saved version)
+++ (current document)
@@ -11,7 +11,7 @@
items = response.data;
for (i = 0; i < items.length; i++) {
div = $('#' + items[i].id);
- div.append(items[i].admin_hover).addClass('has-admin_hover').addClass(object + '-has-admin_hover');
+ div.prepend(items[i].admin_hover).addClass('has-admin_hover').addClass(object + '-has-admin_hover');
admin_hover_hover(div, object);
}
}

admin_hover.css

/* Line 3: */
.has-admin_hover {
position:relative;
}

/* Line 16: */

.admin_hover {
position: absolute;
right: 0px;
top: 0px;
z-index: 10000;
padding: 2px 2px 2px 0;
background: #fff;
}

 
 

Drupal is a registered trademark of Dries Buytaert.