Closed (duplicate)
Project:
Drupal core
Version:
7.x-dev
Component:
menu system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Jul 2009 at 16:45 UTC
Updated:
3 Jul 2009 at 21:31 UTC
There are two issues here. First, the performance of rebuilding the menu is horrible: #302638: No-op and slow queries during menu rebuild Second, I challenge the assumption that viewing the modules page is the right time to rebuild the router table. After all, how could this NOT be slow when simply getting the form does this?
function system_modules($form_state = array()) {
// Clear all caches.
registry_rebuild();
drupal_theme_rebuild();
node_types_rebuild();
cache_clear_all('schema', 'cache');
// Get current list of modules.
$files = system_get_module_data();
I suggest we move all that crud to the submit handler.
| Comment | File | Size | Author |
|---|---|---|---|
| kill_fewer_kittens.diff | 1.18 KB | robertdouglass |
Comments
Comment #1
robertdouglass commentedComment #3
acrollet commentedsubscribing. best patch name evah btw
Comment #4
chx commentedComment #5
chx commented#193366: execute various rebuilds when modules are submitted
Comment #6
beltoftesubscribing
Comment #7
EvanDonovan commentedWell, even if this is a duplicate issue, would there be ill effects if I moved all those function calls to the submit handler in my copy of Drupal 6.x?