Use of padding should be margin instead
eternalistic - July 3, 2009 - 22:09
| Project: | Ubercart |
| Version: | 6.x-2.0-rc3 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
| Issue tags: | theme layer |
Jump to:
Description
I'm in the process of theming the Category image on the Catalog page and with how the code is structured now the CSS reads:
img.category {
float:right;
padding-left:1em;
}And when I apply a border to that image it looks like so:
http://content.screencast.com/users/eternalistic/folders/Jing/media/9644...
The reason the border isn't appearing correctly is due to the "padding-left:1em;". This should instead read "margin-left:1em;". Once changed it looks correct like this:
http://content.screencast.com/users/eternalistic/folders/Jing/media/1639...
Can we please get this changed so it is correct in the module? Thanks for all the hard work!
#1
Committed. Feel free to point out other CSS goofs; we know a lot more now than we did then. : P
#2
Automatically closed -- issue fixed for 2 weeks with no activity.