Emvideo field doesn't *actually* implement hook_requirements
mikey_p - July 3, 2009 - 22:14
| Project: | Embedded Media Field |
| Version: | 6.x-1.x-dev |
| Component: | Embedded Video Field |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
<?php
/**
* Implementation of hook_requirements().
*/
function hook_requirements($phase) {
$requirements = array();
// Ensure translations don't break at install time
$t = get_t();
if ($phase == 'install') {
if (drupal_get_installed_schema_version('content') < 6000) {
drupal_set_message($t("Some updates are still pending. Please return to !update and run the remaining updates.", array('!update' => l($t(), 'update.php', array('query' => 'op=selection')))), 'warning');
$requirements['cck'] = array(
'title' => $t('CCK'),
'description' => $t('Updates for content.module need to be run first.<br/>Please re-run the update script.'),
'severity' => REQUIREMENT_ERROR,
);
}
}
return $requirements;
}
?>Need I say more?
#1
#2
Mikey_p:
I saw your tweet, and I have to say that you're not being very straightforward about the seriousness of this issue. You're assuming that I have some prior knowledge. If this issue is critical to your or other users' use of this module, you should say more.
It would be even better if you provided a patch.
If you cannot provide a patch, you could effectively provoke people like me to action if you give us a clue about why this is critical and what the problem is.
Thanks for your effort to bring an issue to the module maintainers' attention, but you're not helping the cause by being oblique.
(I see that it's the function name. Will you provide the patch or shall I?)
#3
Really, this is kind of funny that this hasn't been fixed even though it's been highly noticed on http://api.lullabot.com/hook_requirements. :)
#4
Hilarious! Thanks for the catch; fixed in dev. I hope to roll a new version this week.
Aaron
#5
Automatically closed -- issue fixed for 2 weeks with no activity.