Download & Extend

Admin toolbar breaks style on Garland when js is disabled.

Project:Drupal core
Version:7.x-dev
Component:toolbar.module
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Quick fix

Issue Summary

If javascript is disabled the toolbar overlaps a part of the header in Garland (on FF3, but probably on others too).

Attached is a screen shot and a patch to fix the problem.

AttachmentSizeStatusTest resultOperations
toolbar-without-js.jpg45.65 KBIgnored: Check issue status.NoneNone
behaving-toolbar-without-js.patch584 bytesIdlePassed: 11562 passes, 0 fails, 0 exceptionsView details

Comments

#1

Title:Admin toolbar brakes style on Garland when js is disabled.» Admin toolbar breaks style on Garland when js is disabled.

#2

#3

Status:needs review» reviewed & tested by the community

Tested in IE6, IE7, IE8 and Chrome on Windows, and the latest versions of Safari, Firefox and Opera on the Mac, all with JavaScript disabled and enabled.

And the code change makes sense too.

#4

I saw a similar overlap with javascript enabled which went away when the page finished loading a few times, looks like a good change.

#5

@catch
Yes, because that class is added by toolbar.js when the DOM is ready. The more time it takes to load, more time you have to notice the problem.

#6

Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.