Download & Extend
Issues

Admin toolbar breaks style on Garland when js is disabled.

Posted by tic2000 on July 4, 2009 at 3:46pm
Project:Drupal core
Version:7.x-dev
Component:toolbar.module
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)
Issue tags:Quick fix

Issue Summary

If javascript is disabled the toolbar overlaps a part of the header in Garland (on FF3, but probably on others too).

Attached is a screen shot and a patch to fix the problem.

AttachmentSizeStatusTest resultOperations
toolbar-without-js.jpg45.65 KBIgnored: Check issue status.NoneNone
behaving-toolbar-without-js.patch584 bytesIdlePassed: 11562 passes, 0 fails, 0 exceptionsView details
Login or register to post comments

Comments

#1

Posted by keith.smith on July 4, 2009 at 4:10pm
Title:Admin toolbar brakes style on Garland when js is disabled.» Admin toolbar breaks style on Garland when js is disabled.

#2

Posted by xmacinfo on July 4, 2009 at 4:16pm

#3

Posted by alpritt on July 5, 2009 at 9:39pm
Status:needs review» reviewed & tested by the community

Tested in IE6, IE7, IE8 and Chrome on Windows, and the latest versions of Safari, Firefox and Opera on the Mac, all with JavaScript disabled and enabled.

And the code change makes sense too.

#4

Posted by catch on July 5, 2009 at 11:25pm

I saw a similar overlap with javascript enabled which went away when the page finished loading a few times, looks like a good change.

#5

Posted by tic2000 on July 6, 2009 at 6:42am

@catch
Yes, because that class is added by toolbar.js when the DOM is ready. The more time it takes to load, more time you have to notice the problem.

#6

Posted by Dries on July 7, 2009 at 7:54am
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#7

Posted by System Message on July 21, 2009 at 8:00am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.