Everytime when exception happens on run.review watchdog receives ONLY internal $code but whole message (reason) is lost.

Same with rpc call - on debug stage we should have ability to view rpc.response data passed.

This could be very helpful when debuging both client and server side

CommentFileSizeAuthor
#7 510176-debug.patch1.82 KBboombatower
#5 pifr_debug.patch1.16 KBandypost
#2 510176-debug.patch1.78 KBboombatower
#1 pifr2_debug.patch1.8 KBandypost
pifr2_debug.patch1.54 KBandypost

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented
StatusFileSize
new pifr2_debug.patch1.8 KB

XML-RPC result should posted after watchdog

boombatower’s picture

boombatower commented
StatusFileSize
new 510176-debug.patch1.78 KB

Changed to straight up watchdog() calls.

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Needs review » Fixed

This was committed, forgot to update status.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Fixed » Needs work

@boombatower Logging all XML-RPC into watchdog is expensive so better leave this for pifr_debug()!

So when debug is disabled (production) watchdog stays clean.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Needs review
StatusFileSize
new pifr_debug.patch1.16 KB

Another opinion - responce could be big and make bot slower

boombatower’s picture

boombatower commented

Question to make sure then since PIFR_DEBUG still makes it run a single test...is this what you want?

boombatower’s picture

boombatower commented
StatusFileSize
new 510176-debug.patch1.82 KB

Final patch.

boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.