Download & Extend
Project Issue File Review » Issues

Debug info was lost

Posted by andypost on July 4, 2009 at 5:06pm
Project:Project Issue File Review
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:boombatower
Status:closed (fixed)

Issue Summary

Everytime when exception happens on run.review watchdog receives ONLY internal $code but whole message (reason) is lost.

Same with rpc call - on debug stage we should have ability to view rpc.response data passed.

This could be very helpful when debuging both client and server side

AttachmentSize
pifr2_debug.patch1.54 KB
Login or register to post comments

Comments

#1

Posted by andypost on July 4, 2009 at 6:08pm

XML-RPC result should posted after watchdog

AttachmentSize
pifr2_debug.patch 1.8 KB

#2

Posted by boombatower on July 9, 2009 at 12:58am

Changed to straight up watchdog() calls.

AttachmentSize
510176-debug.patch 1.78 KB

#3

Posted by boombatower on July 17, 2009 at 7:52pm
Assigned to:Anonymous» boombatower
Status:needs review» fixed

This was committed, forgot to update status.

#4

Posted by andypost on July 24, 2009 at 12:29am
Status:fixed» needs work

@boombatower Logging all XML-RPC into watchdog is expensive so better leave this for pifr_debug()!

So when debug is disabled (production) watchdog stays clean.

#5

Posted by andypost on July 24, 2009 at 12:38am
Status:needs work» needs review

Another opinion - responce could be big and make bot slower

AttachmentSize
pifr_debug.patch 1.16 KB

#6

Posted by boombatower on July 24, 2009 at 12:56am

Question to make sure then since PIFR_DEBUG still makes it run a single test...is this what you want?

#7

Posted by boombatower on October 28, 2009 at 4:25am

Final patch.

AttachmentSize
510176-debug.patch 1.82 KB

#8

Posted by boombatower on October 28, 2009 at 4:26am
Status:needs review» fixed

Committed.

#9

Posted by System Message on November 11, 2009 at 4:30am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.