Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.The toolbar has placeholders for icons since those were moved into a separate issue, however as it is, it just looks like they're missing.
This leads to responses like:
* wwwebernet wonders if there are supposed to be images with the new toolbar...
So when icons go in, we can put back the CSS and spans, but until then it's confusing cruft.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | icons-toolbar.patch | 1.45 KB | mavimo |
| #11 | path-admin.png | 1.66 KB | mavimo |
| #11 | path-admin-content.png | 1.4 KB | mavimo |
| #11 | path-node-add.png | 808 bytes | mavimo |
| #9 | toolbar-icon.patch | 740 bytes | mavimo |
Comments
Comment #1
catchNow I agree it looks exceptionally plain without the placeholders, but it doesn't want me make to look in the net tab of firefox for 404s either.
Comment #2
catchComment #3
dries commentedThe goal is to get icons in, so why not keep the example code in for now? With the placeholder, we're more likely going to get icons. For me this is a 'postpone'.
Comment #4
catchThe placeholders make it look like there's active work to get the icons in (if there is I'm unaware of any patches which have been updated in the past month) and "oh they'll be adding those later" or "they must have just been missing from the commit" - as in wwwebernet's irc comment.
No placeholders makes it look like "wtf that header looks boring, someone should really add some icons to it", which more accurately reflects the current situation and may provoke some people into contributing some.
However if we really want to provoke people into contributing icons, maybe we need some really, really ugly placeholders instead.
Comment #5
dries commentedIt doesn't make sense to put in ugly placeholders. What we have now are fine placeholders. Let's continue to focus our efforts on things that are more important, and revisit this issue at the appropriate time.
Comment #6
catchI'm going to post here every time someone asks in irc why the icons aren't showing up in the header, but otherwise not going to push this one further.
Comment #7
gábor hojtsycatch: The reason for the placeholders are exactly so that people ask that question ;) So the more often you update this issue (per #6), the better. Let's get them understand there should be icons there and get them actually work on the icons as a consequence.
Comment #8
babbage commentedIn terms of troubleshooting other issues with the toolbar (e.g. how it will behave when viewed in narrow viewports: #515334: D7UX toolbar: Usability in narrow viewports) it is helpful to have these placeholders there, providing they are approximately the width we expect any final icons to be...
Comment #9
mavimo commentedPatch to add icons to toolbar and relative icons. Icons are avaiable also in SVG from www.gnome-looks.org, but can be change.
Comment #10
gábor hojtsy@mavimo: sorry to let you down, but the shortcut bar is not static and it is supposed to be customizable. We really need a much bigger set of icons instead of hard-wiring icons to items. See #511286: D7UX: Implement customizable shortcuts.
Comment #11
mavimo commentedThis patch find if icons are avaible into /BASEPATH/modules/toolbar/icons folder (icons must be named ad path-xxx-yyy-zzz.png), if avaiable load it otherwise hide image placeholder.
Folder can also moved to misc directory or subfolder and icons can be add time by time.
To test this patch add /modules/toolbar/icons folder and put attached image into it.
PS: image are only DEMO!
Comment #12
gábor hojtsyOk, once again #511286: D7UX: Implement customizable shortcuts is where icon association to shortcuts is dealt with :) This issue is postponed.
Comment #13
catchComment #14
catch#602408: Adjust height of shortcut bar