Should toolbar depend on menu module? (for menu_custom table)

asimmonds - July 4, 2009 - 22:08
Project:Drupal
Version:7.x-dev
Component:toolbar.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

After installing Drupal with the minimal installation profile (expert.profile), then enabling the new toolbar module, I get:

PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'drupalcvs.menu_custom' doesn't exist: INSERT INTO {menu_custom} (menu_name, title, description) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_0] => admin_shortcuts [:db_insert_placeholder_1] => Administration shortcuts [:db_insert_placeholder_2] => The <em>Admininstration shortcuts</em> menu contains commonly used links for administrative tasks. )  in toolbar_install() (line 23 of modules/toolbar/toolbar.install).

So, should toolbar depend on menu.module or does this expose a bigger issue in the way the menu's are configured? ie should menu_custom be a permanent table?

#1

Jody Lynn - July 5, 2009 - 17:58
Status:active» needs review

Yes, I think toolbar needs a menu dependency.

AttachmentSize
toolbar-info.patch 559 bytes
Testbed results
toolbar-info.patchpassedPassed: 11563 passes, 0 fails, 0 exceptions Detailed results

#2

Gábor Hojtsy - July 6, 2009 - 07:01
Status:needs review» reviewed & tested by the community

Yes, agreed.

#3

Dries - July 6, 2009 - 13:54
Status:reviewed & tested by the community» fixed

Committed to CVS HEAD. Thanks.

#4

System Message - July 20, 2009 - 14:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.