Using the module return a watchdog message 'trash.gif' not found.
This is because a wrong url for trash gif is built in line 160 of the module:

The actual module in line 160 uses: url("misc/trash.gif")
instead of the correct "misc/trash.gif"

This builds the incorrect url.

Since I'm not familiar with diff and patches, if someone can update CVS....

Matteo

Comments

ax’s picture

ax commented
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

It should use the somewhat new theme("image", ...) instead so themes can override it if needed...

ax’s picture

ax commented

don't know. this is in a themeable function (theme_bookmarks_del()) already ...

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

There are a lots of themeable functions using theme("something", ...), since it is easier to define mytheme_image() and then know that it will work for all images, compared to defining all the theme functions for everything using images...

I am the current manitainer of bookmarks module, but I am presently (these days) not able to modify it in CVS, so hereby I grant any modification concerning the theme("image", ...) issue we are discussing here...

ax’s picture

ax commented

modified accordingly

Anonymous’s picture

(not verified) commented