drupal_render($function()) causes strict warnings

Posted by alpritt on July 5, 2009 at 12:41am

Issue Summary

This construct...

drupal_render(drupal_get_form('some_form'))

... is causing a bunch of strict warnings.

Comments

#1

Posted by alpritt on July 5, 2009 at 7:15am

Title:

Strict warning: Only variables should be passed by reference

» drupal_render($function()) causes strict errors

From http://drupal.org/node/353069#comment-1552904 where this was introduced:

We should *not* be using drupal_render() in module code. Modules need to pass back arrays, not strings. There are very few legitimate uses for drupal_render() beyond drupal_render_page(). Just a few theme functions that need to ccarefully control their output. I added some drupal_render() calls because refactoring spaghetti like comment module is beyond the scope of this patch. I'll do it, but not here.

So a patch for this issue needs to fix code that *does* require drupal_render() (such as in install.php), and then make sure we have issues for fixing other occurrences The Right Way.