I just installed head and followed the installer's link to more help, but the link was dead since help module was not enabled (minimal profile). Patch only shows that text if help is enabled.

Comments

Status: Needs review » Needs work

The last submitted patch failed testing.

jody lynn’s picture

Status: Needs work » Needs review

retest?

jody lynn’s picture

StatusFileSize
new1.26 KB

Status: Needs review » Needs work

The last submitted patch failed testing.

David_Rothstein’s picture

Title: Installer links to help module even when it is disabled » Installer links to help module and other pages even when they are not available
Status: Needs work » Needs review
StatusFileSize
new2.41 KB

Yeah, I had submitted something similar as part of a quick followup to #475596: [meta-issue] Fix the unholy abomination that is the welcome screen (the issue where the change was introduced). My theory was that submitting it there would lead to a quick RTBC and commit, but that was a month and a half ago now :) So keeping it as a separate bug report is probably better.

The attached patch should apply against HEAD and also fixes a related issue that was introduced at the same time (similar links on the default front page were being shown to users who would get "access denied" when visiting them).

jody lynn’s picture

Status: Needs review » Reviewed & tested by the community

Thank you

dries’s picture

Good catch! Committed to CVS HEAD. Thanks.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.