Download & Extend
Issues

Installer links to help module and other pages even when they are not available

Posted by Jody Lynn on July 5, 2009 at 5:53pm
Project:Drupal core
Version:7.x-dev
Component:install system
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I just installed head and followed the installer's link to more help, but the link was dead since help module was not enabled (minimal profile). Patch only shows that text if help is enabled.

AttachmentSizeStatusTest resultOperations
help-install.patch1.26 KBIdleFailed: Failed to apply patch.View details
Login or register to post comments

Comments

#1

Posted by System Message on July 28, 2009 at 8:55pm
Status:needs review» needs work

The last submitted patch failed testing.

#2

Posted by Jody Lynn on August 10, 2009 at 3:42am
Status:needs work» needs review

retest?

#3

Posted by Jody Lynn on August 10, 2009 at 9:37pm
AttachmentSizeStatusTest resultOperations
help.patch1.26 KBIdleFailed: Failed to apply patch.View details

#4

Posted by System Message on August 10, 2009 at 9:47pm
Status:needs review» needs work

The last submitted patch failed testing.

#5

Posted by David_Rothstein on August 10, 2009 at 10:07pm
Title:Installer links to help module even when it is disabled» Installer links to help module and other pages even when they are not available
Status:needs work» needs review

Yeah, I had submitted something similar as part of a quick followup to #475596: [meta-issue] Fix the unholy abomination that is the welcome screen (the issue where the change was introduced). My theory was that submitting it there would lead to a quick RTBC and commit, but that was a month and a half ago now :) So keeping it as a separate bug report is probably better.

The attached patch should apply against HEAD and also fixes a related issue that was introduced at the same time (similar links on the default front page were being shown to users who would get "access denied" when visiting them).

AttachmentSizeStatusTest resultOperations
broken_links_in_welcome_help_2.patch2.41 KBIdlePassed: 12085 passes, 0 fails, 0 exceptionsView details

#6

Posted by Jody Lynn on August 11, 2009 at 1:40pm
Status:needs review» reviewed & tested by the community

Thank you

#7

Posted by Dries on August 12, 2009 at 12:39pm

Good catch! Committed to CVS HEAD. Thanks.

#8

Posted by webchick on August 12, 2009 at 3:08pm
Status:reviewed & tested by the community» fixed

#9

Posted by System Message on August 26, 2009 at 3:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.