Closed (fixed)
Project:
Advertisement
Version:
6.x-2.x-dev
Component:
ad_channel module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Jul 2009 at 07:55 UTC
Updated:
14 Apr 2011 at 08:21 UTC
Jump to comment: Most recent file
Comments
Comment #1
dpopov commented"node" (without quotation marks) works for front page.
Comment #2
BarisW commentedYou are right (in my case node/120). I think should be accepted as well, as is used everywhere in Drupal to refer the front page.
Comment #3
jeremy commentedUsing
<front>works fine for me, though it was not documented as being supported. I've fixed the documentation. If you're still having a problem, please re-open this issue and follow the directions in documentation/DEBUG.txt.Comment #5
Countzero commentedThe tag doesn't work with Drupal 6.13 and Ad 6.x-2.1.
Specifying node/xxx (the node set as front) works.
Thanks for your work on this excellent module.
Comment #6
jeremy commented> If you're still having a problem, please re-open this issue and follow
> the directions in documentation/DEBUG.txt.
If you don't follow the directions in documentation/DEBUG.txt, I'm unable to help you.
Comment #7
jeremy commentedNo further feedback, closing issue.
Comment #9
lesleyfernandes commentedSame here.
Version 6.x-2.2
Comment #10
lesleyfernandes commentedI'm using the node id(node/xxx) but if I change the front page I need to change all the channels =/
Comment #11
john franklin commentedThe Channel module uses
adserve_variable()when it should be usingvariable_get(). Patch attached.Comment #12
BarisW commentedComment #13
anonymous07 commented@John Franklin: Thanks for the patch. Unfortunately, it seems to be in a different format than others I have applied.
When I do:
I get:
And it waits for input. This occurs from the ad directory or the ad/channel directory
Can you please advise?
Comment #14
john franklin commentedThe
-poption says how many levels of path name to ignore. You need to strip of at least the git a/b part of the path, so you need at least a-p1. Do the following:Comment #15
anonymous07 commentedThank you for the followup. I was able to successfully apply the patch.
The Channel behavior is still not right; but honestly I did not test the <front> functionality which your patch is supposed to address. I was more hopeful that it might fix the channel url wildcards somehow and it did not appear to.
I will have to test more (and specifically the <front> functionality) and report back.
Comment #16
john franklin commentedCommitted to 6.x branch as 4635ffa. Port to 7.x branch needed.
Comment #17
john franklin commentedThis code doesn't exist yet in the 7.x branch.
Comment #18
anonymous07 commentedFirst, I want to thank John and other contributors for their time and dedication to this.
I am just noting that this code still did not work for me and I communicated the issues/Debug to John.
When I try to use Channels, whether <front> or otherwise, it only shows 1 ad everywhere (similar to setting an ad as "Premiere"). My workaround for channels has been to use different Ad Groups containing the ads I want for a particular website/location. (I have hundreds of ads I can test with).
BTW, I use mostly remote ads with one site serving the ads to numerous others. I don't really using "local" ads that much (i.e., ads in within the same site where they reside).
Cheers
Comment #19
anonymous07 commented@John, I sent you more debug output after conducting a simple experiment with 2 channels (one that should show only on front and one that shouldn't show on front) where an ad that should only show on <front> showed on a non-<front> page.
Hope this helps.
Comment #20
john franklin commentedThanks, I got it.
Comment #21
anonymous07 commentedThanks John. I really want to thank you for all the work you have done on this module in such a short time as well.
It is highly appreciated.