I want to display a channel only on the front page. If I enter on the URL rules settings, they aren't displayed.
When I remove , they are displayed, so the rest of my Ad settings are working fine.

CommentFileSizeAuthor
#11 ad-frontpage.patch836 bytesjohn franklin

Comments

dpopov’s picture

"node" (without quotation marks) works for front page.

BarisW’s picture

Category: bug » feature

You are right (in my case node/120). I think should be accepted as well, as is used everywhere in Drupal to refer the front page.

jeremy’s picture

Status: Active » Fixed

Using <front> works fine for me, though it was not documented as being supported. I've fixed the documentation. If you're still having a problem, please re-open this issue and follow the directions in documentation/DEBUG.txt.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Countzero’s picture

Version: 6.x-2.0 » 6.x-2.1
Component: ad module » ad_channel module
Category: feature » bug
Status: Closed (fixed) » Active

The tag doesn't work with Drupal 6.13 and Ad 6.x-2.1.

Specifying node/xxx (the node set as front) works.

Thanks for your work on this excellent module.

jeremy’s picture

Status: Active » Postponed (maintainer needs more info)

> If you're still having a problem, please re-open this issue and follow
> the directions in documentation/DEBUG.txt.

If you don't follow the directions in documentation/DEBUG.txt, I'm unable to help you.

jeremy’s picture

Status: Postponed (maintainer needs more info) » Fixed

No further feedback, closing issue.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

lesleyfernandes’s picture

Same here.

Version 6.x-2.2

lesleyfernandes’s picture

Status: Closed (fixed) » Active

I'm using the node id(node/xxx) but if I change the front page I need to change all the channels =/

john franklin’s picture

StatusFileSize
new836 bytes

The Channel module uses adserve_variable() when it should be using variable_get(). Patch attached.

BarisW’s picture

Status: Active » Needs review
anonymous07’s picture

@John Franklin: Thanks for the patch. Unfortunately, it seems to be in a different format than others I have applied.

When I do:

sudo patch -p0 < /path/ad-frontpage.patch

I get:

can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/channel/ad_channel.inc b/channel/ad_channel.inc
|index df96cde..09c7f2b 100644
|--- a/channel/ad_channel.inc
|+++ b/channel/ad_channel.inc
--------------------------
File to patch:

And it waits for input. This occurs from the ad directory or the ad/channel directory

Can you please advise?

john franklin’s picture

The -p option says how many levels of path name to ignore. You need to strip of at least the git a/b part of the path, so you need at least a -p1. Do the following:

cd sites/all/modules/ad
patch -p1 < /path/to/ad-frontpage.patch
anonymous07’s picture

Thank you for the followup. I was able to successfully apply the patch.

The Channel behavior is still not right; but honestly I did not test the <front> functionality which your patch is supposed to address. I was more hopeful that it might fix the channel url wildcards somehow and it did not appear to.

I will have to test more (and specifically the <front> functionality) and report back.

john franklin’s picture

Version: 6.x-2.1 » 7.x-2.x-dev
Status: Needs review » Patch (to be ported)

Committed to 6.x branch as 4635ffa. Port to 7.x branch needed.

john franklin’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Patch (to be ported) » Fixed

This code doesn't exist yet in the 7.x branch.

anonymous07’s picture

First, I want to thank John and other contributors for their time and dedication to this.

I am just noting that this code still did not work for me and I communicated the issues/Debug to John.

When I try to use Channels, whether <front> or otherwise, it only shows 1 ad everywhere (similar to setting an ad as "Premiere"). My workaround for channels has been to use different Ad Groups containing the ads I want for a particular website/location. (I have hundreds of ads I can test with).

BTW, I use mostly remote ads with one site serving the ads to numerous others. I don't really using "local" ads that much (i.e., ads in within the same site where they reside).

Cheers

anonymous07’s picture

@John, I sent you more debug output after conducting a simple experiment with 2 channels (one that should show only on front and one that shouldn't show on front) where an ad that should only show on <front> showed on a non-<front> page.

Hope this helps.

john franklin’s picture

Thanks, I got it.

anonymous07’s picture

Thanks John. I really want to thank you for all the work you have done on this module in such a short time as well.

It is highly appreciated.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.