We currently can't override the display of attributes on each product line of an order. I've created a patch to add theme_uc_order_attributes($product) to Ubercart. Patch to follow.

CommentFileSizeAuthor
#5 511846_200907072254-0400.patch3.08 KBsammys
#1 511846_200907061618-0400.patch3.14 KBsammys

Comments

sammys’s picture

sammys commented
StatusFileSize
new 511846_200907061618-0400.patch3.14 KB

Patch attached.

sammys’s picture

sammys commented
Status: Active » Needs review

Set to 'needs review'

rszrama’s picture

rszrama commented

So, it appears to work properly at least, but I have two questions with the patch:

1) In the comments for the function, you say that $product is deliberately ignored, but I don't know what you mean. It's using $product->data right there.
2) You mention $options in the comments for the function, but you don't include it in hook_theme(), the prototype, or when the theme function is called. Is that what's being deliberately ignored? Or should that just be taken out of the comments?
3) Regarding the comments, don't we know the return type? A string, either populated with the option HTML or empty?

sammys’s picture

sammys commented
Status: Needs review » Needs work

Yeah the comments were there when I implemented the code a different way. I'll rework it and resubmit.

sammys’s picture

sammys commented
StatusFileSize
new 511846_200907072254-0400.patch3.08 KB
sammys’s picture

sammys commented
Status: Needs work » Needs review
rszrama’s picture

rszrama commented
Status: Needs review » Fixed

Alrighty, thanks for the cleanup. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.