Currently if you do not include the second argument for the 'install_views_ui_import_from_file' function for importing views, the function simply returns FALSE. This option is an optional field in this function and should either be used as such or should not be optional. I've made a tweak to the function with makes the field optional and which doesn't seem to cause any problems. I'd like to submit it for review.

CommentFileSizeAuthor
#2 views.inc_.name_defaults.patch567 bytesJames Andres
views.inc_.patch602 bytesGekiboy

Comments

Gekiboy’s picture

Gekiboy commented
Status: Active » Needs review
James Andres’s picture

James Andres commented
StatusFileSize
new views.inc_.name_defaults.patch567 bytes

Great observation, not supplying a view name should be allowed. Here's another patch that does the same thing, but simplifies the code a little more.

James Andres’s picture

James Andres commented
Status: Needs review » Fixed

There seems to be no complaints, and this doesn't break the API. Committing.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.