Can't add nodes using autocomplete textbox, titles display as restricted when manipulating queue for own nodes

IncrediBody.com - July 7, 2009 - 01:16
Project:Nodequeue
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:patch (to be ported)
Description

A thread of this title existed at http://drupal.org/node/489354, and I asked a question several days ago pertaining to this specific issue, but when I checked for replies, the thread suddenly disappeared. The topic seems to be quite serious, and others have experienced the "Restricted Node - NID: xxx" when trying to add a node with the newest v2.2 release, so I am not sure why the thread was closed.

My question was whether there is a database change via update.php required when moving up to version 2.2 (I cannot recall if there was), because if not, I will roll back to the previous version until a formal patch has been released, unless someone can direct me to the specific solution for this problem so I won't need to downgrade.

Thanks for your help, and I hope this thread does not vanish as quickly as the other :-)

#1

scor - July 8, 2009 - 16:52
Status:active» fixed

fixed with SA-CONTRIB-2009-041.

#2

IncrediBody.com - July 13, 2009 - 06:30

I upgraded to v2.3, and I still receive the "Restricted Node - NID:" error when I try to add a node. Any ideas? Everything was working perfectly fine prior to v2.2, and 2.3 hasn't solved the problem for me. Please let me know if you can help.

Thanks!

#3

scor - July 13, 2009 - 07:37
Version:6.x-2.2» 6.x-2.3
Status:fixed» active

switching to active if this is still a problem. (won't have time to look into it myself but hopefully someone will).

#4

IncrediBody.com - July 13, 2009 - 07:56

This is definitely still a problem, as I encountered the "Restricted Node - NID:" with v2.3, and am seeking a solution.

#5

ezra-g - July 13, 2009 - 14:34
Status:active» postponed (maintainer needs more info)

What happens when using the same Drupal user account you browse to view the node you are trying to add?

#6

IncrediBody.com - July 14, 2009 - 01:03
Status:postponed (maintainer needs more info)» active

When I try to add a node to the nodequeue list, the title is shown as "Restricted Node - NID: 434", which is not clickable, so I cannot actually visit the node in question from Nodequeue. If I type node/434 in my browser, node 434 displays fine, so there is no issue with the node itself.

#7

ezra-g - July 14, 2009 - 01:03
Status:active» postponed (maintainer needs more info)

But you can see the node id. So go to node/nid. What do you see?

#8

ezra-g - July 14, 2009 - 01:05

Sorry, read that too quickly and missed the 2nd part of your issue. Are you using any access control modules?

#9

ezra-g - July 14, 2009 - 01:06

Also, are you logged in as the user who authored the node in question?

#10

IncrediBody.com - July 14, 2009 - 05:15
Status:postponed (maintainer needs more info)» active

What would be an example of an access control module? If this refers to a module that is designed to simplify or modify permissions, then I am not.

Regarding your second question, I am logged in as the user who authored the node that I am trying to add. Prior to v2.2 I had no problems adding nodes (I am currently running the latest v2.3).

#11

IncrediBody.com - July 16, 2009 - 20:47

Is anyone else experiencing this problem? Any ideas as to a solution?? If not, does anyone know if there was an update.php database change since 2.1, because if there was not, I'll move back to 2.1 on my localhost so I can at least finish developing my Nodequeue list while someone determines why this "Restricted Node" error is occurring.

#12

ezra-g - July 16, 2009 - 21:12
Title:Latest Build broke Nodequeue - can't add nodes» Can't add nodes using autocomplete textbox, titles display as restricted when manipulating queue for own nodes
Priority:critical» normal

Thanks for helping us identify the problem.

The problem here is actually that the queue administration screen won't let you see the title of your own nodes. You can still add nodes using the AJAX links, and you can still manipulate their order in the queue. The queries that restrict nodes simply don't take into account that you should be able to view your unpublished nodes. This needs to be fixed.

In the meantime, you can use the ajax links, or publish the nodes. I advise against downgrading to the insecure release.

#13

IncrediBody.com - July 17, 2009 - 00:07
Title:Can't add nodes using autocomplete textbox, titles display as restricted when manipulating queue for own nodes» Latest Build broke Nodequeue - can't add nodes
Priority:normal» critical

Thanks very much for your reply. I actually never tried saving the queue because of the "Restricted Node" message, but after your latest reply, I did so, and after saving, the "Restricted Node" message is replaced by the node title. So, as you've mentioned, nodequeue is only preventing display of the title during the process of adding, but once saved, the added nodes display with their titles and can be manipulated as desired.

Thanks again for your assistance!

#14

ezra-g - July 17, 2009 - 05:04
Priority:critical» normal

Thanks -- glad to hear that worked for you, and hope to have a fix soon.I don't believe this qualifies as a critical issue, unless you can provide a reason otherwise.

#15

ezra-g - July 17, 2009 - 05:04
Title:Latest Build broke Nodequeue - can't add nodes» Can't add nodes using autocomplete textbox, titles display as restricted when manipulating queue for own nodes

#16

IncrediBody.com - July 17, 2009 - 06:01
Title:Can't add nodes using autocomplete textbox, titles display as restricted when manipulating queue for own nodes » Latest Build broke Nodequeue - can't add nodes
Priority:normal» minor

You are correct in saying that this is not a critical issue, as I originally thought that the "Restricted Node" message signaled that Nodequeue was not allowing me to add the node, which prompted me to classify this as critical, but this is not the case.

Thanks again for your assistance!

#17

ezra-g - July 22, 2009 - 00:52
Priority:minor» normal
Status:active» needs review

Here is a quickly made patch that tries to address this problem. @IncrediBody.com and others - Can you test this?

AttachmentSize
512086.patch 2.81 KB

#18

ezra-g - July 24, 2009 - 20:13
Title:Latest Build broke Nodequeue - can't add nodes» Can't add nodes using autocomplete textbox, titles display as restricted when manipulating queue for own nodes

Please stop changing the title of this issue.

#19

brenk28 - July 29, 2009 - 14:14

The patch did not work for me.

(To be clear, I am adding nodes to a queue via ajax in the admin screen: /admin/content/nodequeue/X/view)

The problem in this case I don't think has anything to do with permissions or published/unpublished, or anything in nodequeue_nids_visible function. It is the fact that it is calling this function to begin with in the ajax case. That function returns a list of nids in the queue, and in the ajax case, the nid you are adding is simply not in the queue yet, so you get that message.

One easy way to get rid of the message would be to add the new nid to the $nids_visible before the check is done in the nodequeue_arrange_subqueue_entry function.

#20

psychoman - August 10, 2009 - 11:03

Could you please write about this issue on the release page? I spent a lot of time wondering what's wrong with my nodes )

#21

ezra-g - August 17, 2009 - 21:40
Title:Can't add nodes using autocomplete textbox, titles display as restricted when manipulating queue for own nodes » Can't add nodes using autocomplete textbox, titles display as restricted when manipulating queue for own nodes
Status:needs review» needs work

This patch needs work.

@psychoman I can't post about every bug on the project page, so I'm going to leave this off for now. It's at the top of the queue and has 20 followups, so it should be pretty visible to folks.

#22

ezra-g - August 27, 2009 - 16:41
Status:needs work» needs review

This patch is against HEAD.

Looks like we bypassed nodequeue_nids_visible with #234004: Drag and drop node ordering and while that wasn't the cause of this problem, this patch also takes care of that.

This works in my testing for users with and without the administer nodes permission. I tested both with nodes that were published, unpublished, and unpublished and by the current author.

I'm tempted to apply this but would love to get a review from one of the many people experiencing this issue. Thanks!

AttachmentSize
512086.patch 2.53 KB

#23

ezra-g - August 27, 2009 - 19:19
Version:6.x-2.3» 6.x-2.x-dev

Bumping version #.

#24

ezra-g - August 27, 2009 - 20:43
Status:needs review» fixed

This was committed along with the fix for http://drupal.org/node/442320. In any case, I think this is the right fix.

#25

capellic - August 28, 2009 - 22:12
Status:fixed» needs work

Ezra -

I was having this problem with the 5.x version. I saw that the dev version was also updated on the same day, so I updated to that. I'm still having the problem. I ran update.php.

I hesitate to change the version on thish to 5.x-2.x-dev because it may still be a problem for 6.x-2.x-dev.

#26

ezra-g - August 29, 2009 - 14:09
Status:needs work» patch (to be ported)

This should still be fixed in 6.x, but needs to be ported to the Drupal 5 branch. Thanks for pointing this out.

#27

ezra-g - August 29, 2009 - 14:14
Version:6.x-2.x-dev» 5.x-2.x-dev

#28

capellic - September 14, 2009 - 15:56

Bump.. how is this patch coming along?

THANKS!!!

#29

ezra-g - September 14, 2009 - 16:00

I'm not actively working on this right now but I would be happy to review a patch promptly.

 
 

Drupal is a registered trademark of Dries Buytaert.