Module weight causing node_type_form form_alter to not work (only on install - not update)

Justin W Freeman - July 7, 2009 - 02:45
Project:Comment Upload
Version:6.x-1.0-alpha5
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

I am using:
Drupal 6.9
Comment upload 6.x-1.0-alpha5

When I install comment upload, the options that should be on the admin/content/node-type/ screen don't display.
If I change the module weight with the SQL

UPDATE system SET weight = 1 WHERE name = 'comment_upload';

it works.

It seems strange that I should have this issue and no one else on the issue queues seems to.

Can anyone else confirm this problem?
Is it possible that it is an issue with drupal 6.9 and this module?

#1

sjtout - July 10, 2009 - 21:00

I think other people may be seeing this, just describing it differently -- do you think this issue is the same as: http://drupal.org/node/513090 ?

#2

sjtout - July 10, 2009 - 21:09

I can confirm that changing the weight of the module to '1' makes the 'enable' option show up in the content type form; which I guess means my issue reported on http://drupal.org/node/513090 is the same as this.

#3

sjtout - July 10, 2009 - 21:17

Sorry, one last note -- for those unfamiliar with it (as I was), here's a description of the purpose of a module's weight, from the 'Weight' module:

"For most operations involving any module that defines a particular hook, the modules are invoked in order first by weight, then by name."

Module weights can be manipulated via a module (rather than by directly writing in the db), through the Utility module available here:

http://drupal.org/project/util

#4

Justin W Freeman - July 12, 2009 - 23:38

#513090: No upload form does seem to be the same issue.

It can be fixed with a patch to the install file to change the weight.

I will do a patch when I get a few spare minutes.

Thanks.

#5

Justin W Freeman - August 13, 2009 - 07:55
Title:Module weight causing node_type_form form_alter to not work» Module weight causing node_type_form form_alter to not work (only on install - not update)
Status:active» needs review

I notice now that it only affects new installs because there is already code that addresses this in comment_upload_update_6002 but not in comment_upload_install.

This patch addresses this.

It applies to 6.x-1.x-dev and 6.x-1.0-alpha5.

AttachmentSize
comment_upload_install_system_weight.patch 425 bytes

#6

Justin W Freeman - August 13, 2009 - 07:57

Please note:

The above patch will only fix the problem if you apply it before installing this module.

If you have already installed it then you have to uninstall and reinstall or do the update manually.

You could also go to yoursiteurl/update.php and run update 6002 for comment_upload because for the time being there are no more updates after that so it won't affect anything else.

#7

DanielTheViking - September 3, 2009 - 23:21

Subscribing.

 
 

Drupal is a registered trademark of Dries Buytaert.