Hi, i'm using your module and it's working great, thank you! However i'm having problems with the attachment fieldset being collapsed by default. I thought part of hunvreus was to expand it by default? Can you help in this matter?

Comments

iva2k’s picture

iva2k commented
Status: Active » Postponed (maintainer needs more info)

I used 100% of hunvreus's code, nothing removed, but I moved it into a module, so the code now is in hooks (compared to theme overrides) that are earlier in the processing call chain. That makes them more easily affected - hooks may be overridden by hooks in other modules.

Here's the function that does the uncollapsed fieldset:

function _itweak_upload_upload_form_alter(&$form, $form_state, $type) {
  drupal_add_js(drupal_get_path('module', 'itweak_upload') . '/itweak_upload.js');
  $form['attachments']['#collapsible'] = 0;	//FIXME: make configurable
  $form['attachments']['#collapsed'] = 0;	//FIXME: make configurable
  $form['attachments']['#title'] = t('Attach files to this @type', array('@type' => $type));
  global $user;
  $limits = _upload_file_limits($user);
  $form['attachments']['#description'] = ($limits['resolution'] ? t('Images are larger than %resolution will be resized. ', array('%resolution' => $limits['resolution'])) : '') . t('Files must be smaller than %filesize and have one of the following extensions: %extensions.', array('%filesize' => format_size($limits['file_size']), '%extensions' => $limits['extensions']));
  $form['buttons']['#weight'] = 100;
}

As you can see, it is currently hardcoded to remove both collapsible and collapsed settings. I planned to do a setting later on, but it is not there yet.

First try to clear all caches & theme registry, but I have a hunch that it won't help.

Second, if you are comfortable searching around your installed drupal code, you can track a problem by grepping for ['attachments']['#collapsible'], and see where else it is used.

If not, You can try disabling all other modules temporarily (except itweak_upload and upload) and see if the fieldset gets uncollapsed. Last resort would be to move module's weight down (make it bigger) in the system table of the database.

If nothing from the above helps, I will need more information from you - what other modules do you have enabled? What theme do you use? What versions?

RickR-1’s picture

RickR-1 commented

Thanks for your reply! I have also tried to uncollapse manually via template overrides, which didn't work either.

Yes, i feel comfortable grepping for ['attachments']['#collapsible'] however my host doesn't provide shell access and I don't feel like migrating....sucks

Which files should I look at specifically? I can check them manually.

Here are the modules i'm currently using:
Core: aggregator, color, comment, contact, DB logging, menu, php filter, poll, search, statistics, taxonomy, tracker, upload

Others: Adsense, CCK, Date/Time, ImageCache, Location, FAQ, moderation, teaser thumbnail, iTweak Upload, CAPTCHA, google analytics, taxonomy menu, fivestar and voting API

Thanks!

iva2k’s picture

iva2k commented

If you don't have shell access, you still can make local image of your installation and search in it. I have no idea which module might be causing it.

I don't see any possible suspects in your module list. What is the theme? Maybe you can try it with different theme?

Sandlot’s picture

Sandlot commented

I was experiencing the same problem. When I added weight the problem went away and iTweak loading last does not seem to interfere with anything else.

When I figure out what was mucking about with iTweak, I will post it here.

iva2k’s picture

iva2k commented

Thanks for narrowing it down to weight issue.

A good starting point would be a posted list of all modules you have enabled - maybe one or two more user reports will intersect it to a couple of suspects. Will certainly save you some tedious debug time. Also, having a long list of modules I can quickly narrow it down to few just looking at their code for which ones are altering specific forms in module_form_alter() function.

iva2k’s picture

iva2k commented
Status: Postponed (maintainer needs more info) » Fixed

I guess weight fix in #4 works.

I've increased weight to 10 in 6.x-2.x-dev

Closing for now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.