"Quote values" does not quote header cells

alex_b - July 7, 2009 - 15:45
Project:Views Bonus Pack
Version:6.x-1.x-dev
Component:Views Export
Category:bug report
Priority:normal
Assigned:Unassigned
Status:fixed
Description

I select "quote values" from the CSV display plugin's options and views_export quotes all values in rows but the header row.

Some of the header values contain the separator character (,) and as a result my CSV files break. Will follow up with patch asap.

#1

alex_b - July 7, 2009 - 15:48
Assigned to:alex_b» Anonymous
Status:active» needs review

Attached patch formats headers just as themed_rows are being formatted. Works fine on my web site, will push this to production now. Looking forward to reviews.

AttachmentSize
512630-1_quote_headers.patch 955 bytes

#2

alex_b - October 8, 2009 - 22:11

ping?

#3

andreiashu - October 16, 2009 - 16:08
Status:needs review» reviewed & tested by the community

Hi,

I just looked over your patch and it looks good. It shouldn't do anything wrong.

RTBC?

#4

neclimdul - December 4, 2009 - 23:23
Status:reviewed & tested by the community» fixed

It didn't actually apply but I pulled the code out and committed it.

#5

alex_b - December 4, 2009 - 23:29

thank you.

 
 

Drupal is a registered trademark of Dries Buytaert.