Download & Extend
Views Bonus Pack » Issues

"Quote values" does not quote header cells

Posted by alex_b on July 7, 2009 at 3:45pm
Project:Views Bonus Pack
Version:6.x-1.x-dev
Component:Views Export
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I select "quote values" from the CSV display plugin's options and views_export quotes all values in rows but the header row.

Some of the header values contain the separator character (,) and as a result my CSV files break. Will follow up with patch asap.

Login or register to post comments

Comments

#1

Posted by alex_b on July 7, 2009 at 3:48pm
Assigned to:alex_b» Anonymous
Status:active» needs review

Attached patch formats headers just as themed_rows are being formatted. Works fine on my web site, will push this to production now. Looking forward to reviews.

AttachmentSize
512630-1_quote_headers.patch 955 bytes

#2

Posted by alex_b on October 8, 2009 at 10:11pm

ping?

#3

Posted by andreiashu on October 16, 2009 at 4:08pm
Status:needs review» reviewed & tested by the community

Hi,

I just looked over your patch and it looks good. It shouldn't do anything wrong.

RTBC?

#4

Posted by neclimdul on December 4, 2009 at 11:23pm
Status:reviewed & tested by the community» fixed

It didn't actually apply but I pulled the code out and committed it.

#5

Posted by alex_b on December 4, 2009 at 11:29pm

thank you.

#6

Posted by System Message on December 18, 2009 at 11:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.