When 'add a link to the original image' is enabled, this link is always added on resized images even when an existing hyperlink is already spanning the image.

This turns
<a href="mylink"> <img src="image.png" width="200" /> </a>
into
<a href="mylink"> <a href="image.png"><img src="resize/image-200x200.png" width="200" /></a> </a></a>

Which is an HTML syntax error and causes the image to no longer lead to the 'mylink' URL.

The current workaround is either to disable 'link to original' altogether, or upload the affected image in the correct size so that image resize filter leaves it unaffected.

CommentFileSizeAuthor
#3 image_resize_filter_double_link.patch2.2 KBquicksketch

Comments

florisla’s picture

florisla commented

Note that my original description above contains a typo. The correct (i.e. typo-free) output reads like:

<a href="mylink"> <a href="image.png"><img src="resize/image-200x200.png" width="200" /></a> </a>

I suspect a solution would involve some regex trickery to determine whether the <img> lies in an opened <a> tag.

mxmilkiib’s picture

mxmilkiib commented

subscribe

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Fixed
StatusFileSize
new image_resize_filter_double_link.patch2.2 KB

I've committed this patch which checks to see if the image is wrapped in an <a> tag. Note that this still will not be perfect since there might be an anchor tag around not only the image but also other tags. For example the following would not be corrected:

<a href="/">
  <span><img src="example.png" width="100" height="100" /></span>
</a>

However such situations are rare compared with wrapping the image in a link directly. Whitespace is still allowed between the anchor and the img tag.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.