The latest version of jQuery is 1.3, and it doesn't use the @ symbol when selecting attributes. This was apparently deprecated in 1.2, which Drupal 6 uses on its own. Let's remove the @ from the [@name=...] selectors in Ubercart, and anything else that we can do to support both versions of jQuery.

CommentFileSizeAuthor
#3 513746_jquery_2x_update.patch15.62 KBIsland Usurper

Comments

tr’s picture

tr commented

http://docs.jquery.com/Release:jQuery_1.3#Changes

The @ symbol change is number one on that list. The next two on the list sound like they could be a problem too...

vm’s picture

vm commented

just ran into this myself. Luckily I have ubercart running our store in a multisite on its own subdomain. This made it easy to remove jquery_update which uses jQuery 1.3.2, from the store only.

Island Usurper’s picture

Island Usurper commented
Status: Active » Needs review
StatusFileSize
new 513746_jquery_2x_update.patch15.62 KB

Not only should the [@foo=...] be removed, but I can finally get rid of the .end() calls that are scattered through the uc_quote code. It was necessary in Drupal 5 for people who didn't have jquery_update, but it would break for people who did use it. Now I think Ubercart will work with or without jquery_update.

Island Usurper’s picture

Island Usurper commented
Status: Needs review » Fixed

Yes, Ubercart works with and without jquery_update. Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.