Wrong redirect after user registration.

subscribe

do you get a 404 because of the extra en/? My guess is something needs to change in boost_exit().

/**
 * Implementation of hook_exit(). Performs cleanup tasks.
 *
 * For POST requests by anonymous visitors, this adds a dummy query string
 * to any URL being redirected to using drupal_goto().
 *
 * This is pretty much a hack that assumes a bit too much familiarity with
 * what happens under the hood of the Drupal core function drupal_goto().
 *
 * It's necessary, though, in order for any session messages set on form
 * submission to actually show up on the next page if that page has been
 * cached by Boost.
 */
function boost_exit($destination = NULL) {
  // Check that hook_exit() was invoked by drupal_goto() for a POST request:
  if (!empty($destination) && $_SERVER['REQUEST_METHOD'] == 'POST') {

    // Check that we're dealing with an anonymous visitor. and that some
    // session messages have actually been set during this page request:
    global $user;
    if (empty($user->uid) && ($messages = drupal_set_message())) {
      // FIXME: call any remaining exit hooks since we're about to terminate?

      $query_parts = parse_url($destination);
      $query_parts['path'] = ($query_parts['path'] == base_path() ? '' : substr($query_parts['path'], strlen(base_path())));
      // Add a nocache parameter to query. Such pages will never be cached
      $query_parts['query'] .= (empty($query_parts['query']) ? '' : '&') . 'nocache=1';
      $destination = url($query_parts['path'], $query_parts);
      // Do what drupal_goto() would do if we were to return to it:
      exit(header('Location: ' . $destination));
    }
  }
}

Is it the default user registration form user/register? How are you doing the redirect; rules, module, custom code?

It is the default user/register form using a ?destination=node%2F23. The '%2F' obviously being the urlencoded '/'.

how are you setting destination= what php code do you use to make that happen?
http://drupal.org/project/login_destination
Something else?

Our node is a webform and we are simply using the webform's 'Webform access control' setting that authenticated users only are able to access the form. Webform will then put up a status warning stating that the user, if anonymous, needs to either login or register. Both 'login' and 'register' are links to their pages with a destination pointing back to the current node. The login form works correctly unlike registering.

Would you mind testing to see if this patch fixes this issue?
http://drupal.org/node/513924#comment-1804928

I've definitely been able to reproduce this. Here's how.

I have a multilingual setup using en as the path prefix for english. I have user registration and user login links in the header of all pages that are built like this:

  print l('Login', 'user/login', array('query' => drupal_get_destination());

which results in urls that look like:

<a href="/en/user?destination=news">login</a>

After submitting the form, I end up on /en/en/news?nocache=1. I've tracked this down to boost_exit(). It uses url() to build a new destination after having deconstructed the $destination variable. Since $destination was presumably built by being passed through url() already, we end up with double prefixes.

In the attached patch, I essentially do the inverse of parse_url to rebuild the $destination variable with the new query string.

Thanks for identifying that the problem is with url(). I think the best way to do this is to create a glue_url() function, the exact opposite of parse_url().
http://php.net/parse-url#85963

Try this patch to see if it works

LOL. thats exactly what i was looking for. i was asking everyone at work what the inverse of parse_url() was. I thought about creating a function but wanted to build the simplest patch i could.

I cant test til i get to work tomorrow. I will let you know the outcome then.

committed