Posted by zwhalen on July 8, 2009 at 6:44pm
Jump to:
| Project: | Bibliography Module |
| Version: | 6.x-1.5 |
| Component: | Code |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I came across this while looking for something else, and as far as I can tell, it's an error. That is, there may be some reason for leaving the ul open, but I can't find it. As it is for my configuration, it generates invalid markup.
This is biblio_theme.inc lines 852 and 853:
$output .= '</li> ';
return $output;The easiest fix is to just add the '/ul':
$output .= '</li></ul> ';
return $output;But a better fix might be to make this link part of the same ul block as the ul.biblio-export-buttons that includes the BibTex and XML export links.
Comments
#1
You are correct, it was an error/omission. I also refactored the code to include your suggestion of building all the links together, as well as the hook_link (in biblio.module) so that all the links are built using the same code.
http://drupal.org/cvs?commit=235082
Ron.
#2
Automatically closed -- issue fixed for 2 weeks with no activity.