Download & Extend

Send update notification only if fields change in the user edit form.

Project:Advanced User
Version:6.x-3.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

thank you for a good module,

i noticed that, email is being sent, even when user doesn't update profile and particularly few users haven't logged in for first time and few users have logged in long back.

drupal v 6.13
advuser v 2.3

regards,

Comments

#1

Version:6.x-2.3» 6.x-3.x-dev

hi,

+1 have I the same problem each time user connect mail was send : /

Advanced User Management 6.x-3.x-dev
also i use ldap Authentication with sync password maybe advusr touch this : / cause on local user all work fine

any patch ?

thx

Drupal 6.13
AMFPHP 1.9 Beta 2
Accès au fichier update.php Protégé
Base de données MySQL 5.0.51a
CTools CSS Cache Exists
PHP 5.2.6-1+lenny3
PHP 'register globals' Désactivé
Plafond mémoire de PHP 128M
Serveur web Apache/2.2.9 (Debian) PHP/5.2.6-1+lenny3 with Suhosin-Patch mod_python/3.3.1 Python/2.5.2 mod_perl/2.0.4 Perl/v5.10.0
jQuery UI 1.6

#2

Version:6.x-3.x-dev» 6.x-2.3

I haven't had time to look into the issue yet. 6.x-3.x-dev is unstable and is not meant to be used in production. At the moment though it is an exacting copy of 6.x-2.x-dev.

#3

Same problem. Today I got 1600 emails. I finally shut off the option to send emails on update.

#4

Title:email is sent, even when user doesn't update profile» Send update notification only if fields change in the user edit form.
Version:6.x-2.3» 6.x-3.x-dev
Category:bug report» feature request

The problem here is that Drupal only provides a Save button on the user edit form. The user clicks save when simply wanting to go back to the previous page. To resolve this issue requires saving the user object prior to the submit happening and then comparing every variable on the form and the form itself is variable. Maybe I can compare the before and after serialized image of the user object for equality rather than each field of the form?

#5

Status:active» patch (to be ported)

The attached patch has been created for 6.x-3.x-dev version. To implement this, the account object is saved when the user enters the account edit form. Then 'after_update' the profile update notification function is called only if the before and after image differs. I had to remove the form_build_id from the object field and the object->data serialized array field in both the before and after image to do the comparison because the form_build_id is different between the before and after image.

AttachmentSize
advuser-6.x-3.0.diff 1.97 KB

#6

Status:patch (to be ported)» fixed

User error in selecting the Status field.

#7

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here