Use pager when listing pending revisions
O_o - July 9, 2009 - 09:42
| Project: | Revision Moderation |
| Version: | 5.x-1.3 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | O_o |
| Status: | needs review |
| Issue tags: | pager, pending revisions, revision moderation |
Description
The Pending revisions page should use a pager if there are more revisions to review than the number specified by the $limit parameter in function revision_moderation_get_all_pending_revisions($limit).
Why? Since the Pending revisions page will list all pending revisions of a node1, the list could be filled by revisions of a single node causing other nodes pending revision to not show up in the list.
I'll roll a patch for this soon.
1 This is another issue that should be looked into. In my opinion it does not make sense to list all pending revisions of a node. Only the latest one should be interesting for the reviewers.
#1
This patch introduces a pager to the Pending revisions page.
Note: Due to another bug in
function revision_moderation_get_all_pending_revisions($limit)that fetches all revisions of a node and then lists only the revision with the lowest revision number, the pager might behave a bit weird (i.e. the number of items shown in the list can vary from the $limit). I'll roll a another patch for that in another issue.#2
Same patch as above but with a trailing space character removed from line 291.