First I like the module verry much. I suggest one minor improvement:

- title - because some flags are too similar - if possible in the language of the flag or english

Roman

Comments

blinkingtwelve’s picture

blinkingtwelve commented
Title: Missing title » Add language title to flag filenames
Component: Code » User interface
Assigned: Unassigned » blinkingtwelve

Good suggestion. I'll put Google's English title for each language code to their respective filenames.

blinkingtwelve’s picture

blinkingtwelve commented
Status: Active » Closed (fixed)

Fixed in 5.x-1.4 and 6.x-1.2 upwards.

romansta’s picture

romansta commented
Title: Add language title to flag filenames » Nice implementation - but not my idea

My intention was a little bit different - but my english could be clearer:

How about this: img title="Translate into $language" alt="Translate into $language" ... If the user mouse over, it is a nice hint - I think.

For good (X)HTML "alt" is necessary.

Fast version is the english one, perfect version should be with descriptions in the appropriate language. In my language - german - i.e. "Übersetze in Deutsch".

Roman
----
www.tpzlingen.de

blinkingtwelve’s picture

blinkingtwelve commented
Title: Nice implementation - but not my idea » Show language descriptions when hovering over flags
Status: Closed (fixed) » Postponed

I was under the impression you were referring to the trouble of figuring out which language code belongs to which language when configuring your enabledlangs. Well, that's easier now ;-)

Anyhow, good suggestion (again), be it what you mean or what I think you mean.
I'll add image titles in a 2.x release, as this will change the spec for the flag filename (which will require reconfiguring when upgrading).
Btw, you're welcome to change issue titles but please keep them descriptive.

romansta’s picture

romansta commented

Sounds great to me!

romansta’s picture

romansta commented
Title: Show language descriptions when hovering over flags » Show alt/title attributes when hovering over flags
zoia’s picture

zoia commented

I ve visited the module page to say thanks. This works great and the tooltip suggested above it is a great future that I hope to be integrated soon. Since I dont use block title i can't wait for the new release
Thank you

blinkingtwelve’s picture

blinkingtwelve commented
Status: Postponed » Needs review

Support for (amongst other things) title attributes is now in CVS. Please test!

zoia’s picture

zoia commented

I noticed something strange during testing(the stable release) Although i am in the home page , google opens for translation different pages every time. Once opened in the new window then i can use the menu of the page and go home or other pages. why does this happen?

blinkingtwelve’s picture

blinkingtwelve commented

Zoia, I'm not sure what you mean and how it relates to the topic at hand, #514602: Show alt/title attributes when hovering over flags.
Please submit a separate issue for your problem in which you describe exactly
a) what you did
b) what happened
c) what you expected to happen instead
To test the new features you need a 6.x-2.x CVS snapshot.

zoia’s picture

zoia commented

sorry you are right this is not related to this topic. I will describe the issue in new topic. Is it safe to test the cvs in production site?

blinkingtwelve’s picture

blinkingtwelve commented

Generally speaking, you shouldn't run CVS snapshots on production. Then again, I run the development code on a production site and risks are low due to the simplicity of the module. You will need to reconfigure your enabledflags, though. And despite the name, you can run the 6.x-2.x snapshots on a Drupal 5 site.
And please don't use this issue for anything else than the topic of the issue title. For support questions such as "can I run CVS code in production", open an issue in the "support request" category.

blinkingtwelve’s picture

blinkingtwelve commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.