Anonymous purchase patch

"Yes" - seems a good thing to have these data structures the same. Although I don't agree with moving addresses out of Transactions. Full addresses in the transaction table constitute an auditable history - quite standard design and sometimes a critical requirement.

(Disclaimer: I'm still a Drupal newbie, so that opinion is based on other systems I've used.)

Sime's right. If the user deletes there address, changes there address, what ever, we've lost important information about the transaction. Not to mention some stupid person might delete their address before something ships and then you're really in trouble.

Cool, to confirm then, I still say "YES" the phone number thing. It seems a good idea.

For what it's worth I agree. I just wanted to say thank you and double thank you for taking this on and cleaning it up.

"YES" - phone numbers should be stored, too.

There is on major point, why to store addresses from completed transactions for the future: To retain a complete transaction, even if the user changes his addresses for further transactions. I don't want that history can be rewritten.

Storage could be the same table "ec_address" or the current one "ec_transaction". If you opt for the same, then we must include two flags "address_used" and "address_invisible". This covers two cases:
1. The address is used in one ore more transactions and should not be altered. (address_used)
2. An address which has been used in a transaction is deleted by the user (address_invisible)

Just my 2c

Kurt

I'm working on this a bit right now as well. I've been frustrated by the anon address processing. Particularly that the form only validates the email address, and nothing else. This can be changed easily in this function: address_checkoutapi by modifying how it handles the logged in user.

I basically changed the structure of the case 'validate' so that the logged in test only produces the email form, but both logged in users and anon users are forced to input valid shipping and billing addresses

<code>
/**
 * Implementation of hook_checkoutapi().
 */
function address_checkoutapi(&$txn, $op, $post_op = NULL, $arg4 = NULL) {
  global $user;

  if ($txn == 'address') return TRUE;
  $output = '';

  switch ($op) {
    case 'form':
      if ($txn->shippable) {
        drupal_set_title(t('Choose a shipping and billing address'));
      }
      else {
        drupal_set_title(t('Choose a billing address'));
      }
      $output .= theme('address_checkout_form', $txn);
      $output .= form_submit(t('Continue'));
      return $output;
      
    case 'validate' :
      //Logged in users
      if (!($user->uid > 0)) {
  	      //anonymous users
      	 if (!valid_email_address($txn->mail)) {
          form_set_error('mail', t('Please enter a valid email address'));
        }
      }
      if ($txn->shippable && !$txn->shipping_address) {
          form_set_error('shipping_address', t('You need to select a shipping address.'));        
        }
      if (!$txn->billing_address) {
          form_set_error('billing_address', t('You need to select a billing address.'));
        }
      
      break;

    case 'save':
      $txn->screen++;
      break;

    case 'review':
      if ($txn->shippable) {
        $box['subject'] = t('Shipping and billing address');
      }
      else {
        $box['subject'] = t('Billing address');
      }
      $box['content'] = theme('address_review', $txn);
      return $box;
  }
}

Hmm patch does not work on current CVS, just a note :D if you could get this working that would be one vote for drupal over some other systems

Drupal 4.6.5

Impressed, that you are working on this.

I was about to open a feature request for the anonymous user Shipping and Billing address form ---- the method of handling data.

The way it resets all info - if the user doesn't complete - either the Shipping or Billing address info.

I like your carry over idea and believe most peope are familar with this method.

Is your "Billing Address the same" or "you forgot to enter your postal code" ... and saving the info --- so all they have to do is type in the missing info.

thanks

Druapl 4.6.5

I was just thinking.

I have just moved my work in progress site to a prodcution location and my old work in progress site is still active and on a different database.

I would be very happy to help test this for you... but

that is a very big path - and I'm not that good with big patches - small ones usually ok - but the big ones get me.

I can do the mySQL stuff you mention using phpAdmin.

is there anyway possible that you can get the file in a already patched status?

thanks

I tested your patch with latest ecommerce cvs available but it did not work well. Perhaps you could ellaborate more which version of address.module, store.inc and store.module, you have patched.
Whatever the time and date you specified on top of your patch, i selected those files from cvs and it did not work.
It takes lot of time to update files. it would be better if user can download your corrected files rather than fiddling with ++++ and _ _ _ .
Lot of drupal users are awaiting for this anonymous purchase option for ecommerce module 4.6x

thanks

I have hacked this together for drupal 4.6.x, it is VERY hacky but it all works well.
I am working on this for v 4.7.x at the moment along with a SECPay payment module.
You can see it in action at http://www.saaf.co.uk

I had to hack the address module and various other bits and pieces, but if anyone is interested
I wouldn't mind being actively involved in the development process.
I am not a programmer by profession at the moment (used to be years ago), but it didn't take me too
long to get it working.

There is a lot of stuff in the ecommerce module that needs doing, or that I think needs doing.
I do think it is an excellent piece of work, which is why I think it should surpass zen cart/os commerce/actinic etc.
without too much trouble

The new module changes I am writing I am aiming not to be so "hacky" and commented well so that they are well
recieved. If you want the current code for it just ask and I'll post it...but be warned it ain't pretty!

Thanks

Malcolm

hi Malcolm
Glad to have you one board. Saw your post on the announcement and now here on this ticket - maybe you'd like to subscribe to the mailing list and join on IRC to discuss your ideas and what you want to contribute.

There are some links at the top of the read (if you've not seen them)
http://cvs.drupal.org/viewcvs/drupal/contributions/modules/ecommerce/REA...

.s

I have anon purchasing working fine on 4.6 (you can see it live at http://www.saaf.co.uk)
I modified the Drupal 4.6 database configuration for anon purchase by adding the following to the ec_transaction table

billing_tel
shipping_tel

I didn't need a shipping_mail (i.e. email address) and couldn't really think of a reason for it as if it is going to a different address,
then the likelyhood is that either it is a present, and you don't want to notify that person in that case or
the person is going somewhere else to pick it up. But if it is needed maybe a tick box defaulting to off stating tick this to
send an email to this person?

For Drupal 4.7 there is a ec_transaction_address, however this only contains one
address line, it doesn't specify the telephone number.
It needs a shipping first/last name and the rest of the shipping details as per other address details
I would personally prefer them to be named as per v4.6 i.e. billing_firstname and shipping_firstname etc.
for readability, obviously there is the likelyhood of breaking current code by doing this.

The address form needs modifying to support all of these fields and also to verify that valid data (I
just checked that some data was entered in each field and highlighted the field if it was not entered)
It should also have a tick box in case billing and shipping addresses are the same, or auto fill the shipping if
it is left blank

I need to get this done asap for drupal 4.7 as there are a whole load of other stuff that is missing that I need to get done,
so I'd appreciate any mistakes I've made in the logic

Well, the new address table is a very nice feature when working in the code. instead of $txn->shipping_name or however it was stored you would simply use $txn->address['shipping']->name. Here's where its nice. since we just dump the database objects into the address associative array to add the telephone field you just add it to the table and it will start showing up in both objects(and any arbitrary address type you come up with). Furthermore, rather than copying the billing_* fields to the shipping_* fields when the mentioned checkbox if selected you just set $txn->['shipping'] = $txn['billing']; and its all done.

One step that I didn't take when writing this that would be a good step to getting this done would be to add a address form type. This would let you update the validation and forms accross ec by changing the form object.

What I'm not sure about in this post is that I thought anonymous purchases where working. Is the actual point to add a telephone number to the purchase? Hope this sheds some light on your development.

Anonymous purchase have actually been fixed so I'm going to close this. The only thing not implemented was the phone number and tax idea mentioned. the later can be done with some work and the former can be handled in a seperate feature request.