Update to use feedback-v2.js (and support SSL)
walkah - July 9, 2009 - 18:52
| Project: | Get Satisfaction |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | walkah |
| Status: | closed |
Jump to:
Description
greetings! we ran into an issue on http://store.lullabot.com/ because the module currently hard-codes "http://" for the URL to the JS include from amazon s3.
The attached patch updates the module to use the latest JS file from getsatisfaction and does detection on the current protocol so the proper include is generated . (You can see the patch in action on http://store.lullabot.com/ )
| Attachment | Size |
|---|---|
| gsfn.patch | 2.03 KB |
#1
Hi Walkah,
thanks for sending this patch over.
Is there a reason why you use 2 different calls to drupal_add_js (one inline and one in the footer)?
Keep up the fun,
Francesco
#2
The footer call is probably for performance, so the widget generation doesn't slow the page load.
In any case, the patch works well. I just tested it, so I'm marking it "tested by the community".
#3
Finally got the time to release a 1.2 which includes this patch. See the Changelog for a very surprising change since last release.
Thanks for your contribution,
Francesco
#4
Marking as fixed.
#5
Automatically closed -- issue fixed for 2 weeks with no activity.