Batch API possibly interferes with assigning taxonomy terms in Views Bulk Operations [#515058]

This is possibly related to #363014: success reported but term not applied -- but, I'm adding this in as a new issue because 363014 is for 5.x-1.2, and this issue is for 6.x-1.7 --

When using the Batch API to process taxonomy changes -- ie, Modify node taxonomy terms (views_bulk_operations_taxonomy_action) -- the process appears to complete normally, and a confirmation dialog is displayed, but no terms are added.

When the changes are invoked directly, everything works as it should -- I'm setting this to minor, as it has a clear and easy workaround, but I wanted to add this here if anyone else runs across this.

This was observed on a standard Drupal install in a dev environment -- Drupal 6.12 core, the Garland theme, latest Views, with CCK text fields exposed in the View.

Comments

Comment #1

infojunkie

Vancouver

commented 9 July 2009 at 22:12

A quick test with Batch API and "Modify node taxonomy terms" (using latest VBO dev) worked fine for me. But I can believe that some cases would go wrong as the taxonomy module has lots of ugly special cases. For example: does this occur with every type of taxonomy (list or tree, tags, single or multiple, etc.) ?

Comment #2

bonobo commented 10 July 2009 at 04:28

Status:

Active

» Fixed

This had two taxonomies, and both were simple lists with about 7 terms --

I tried a series of combinations: adding a single term from one taxonomy, a single term from both taxonomies, multiple terms from one taxonomy, multiple terms from both taxonomies, etc --

I also tried different options within the Views config for the options of the "Views Bulk Operations" display style -- the only one that made a difference was switching from the Batch API to the invoking the changes directly --

Given that the functionality is now working (although not with the Batch API, at least on my dev site) this should probably be set to fixed -- in all likelihood, this is a fringe case --

And, if this crops up for other people, then this issue can be reopened --

Comment #3

zach harkey commented 15 July 2009 at 18:06

Priority:	Minor	» Normal
Status:	Fixed	» Active

I am having this same exact issue (6.x-1.7). I am working around it by switching the view Style options to "Invoke them directly" mode and processing in several smaller passes to avoid timeouts. However, this is cumbersome and exactly why the the Batch API is a good thing.

Considering the enormous role that taxonomies play in Drupal websites, and that there is no other viable way to bulk change taxonomy terms, I am raising the Priority to normal.

However, this bug is definitely not fixed, and I would not consider it fringe either. It can easily be reproduced with any combination of basic taxonomies. So I am reverting the Status back to active.

BTW: Did I mention how much I freaking love this module?

Comment #4

bonobo commented 15 July 2009 at 18:27

Status:

Active

» Postponed (maintainer needs more info)

Zach -- are you using the dev version, or the latest stable release --

Based on the maintainer's reply in #1, this might be fixed in the dev branch --

So, let's leave this as postponed -- if it is still present in the the next stable release, we can re-open it, but given that there is a clearly documented workaround, this is more of something that makes one scratch one's head, as opposed to a showstopper.

And, re: "BTW: Did I mention how much I freaking love this module?"

True dat! VBO ROCKS! kratib is THE MAN!

Comment #5

infojunkie

Vancouver

commented 15 July 2009 at 21:39

Status:

Postponed (maintainer needs more info)

» Active

Thanks guys for the kudos :-)

Seems that bug is indeed serious. To clarify, I did not mean it's fixed in the latest dev, I just meant I tried it in the latest dev on my machine, and it worked. Many other things could be different, and one of them could be causing the bug. I'll try to reproduce it again.

If you have more hints, please share them.