Paypal API (GetExpressCheckoutDetails) is returning the zone value of SHIPTOSTATE in different formats for different countries.
For US addresses it is zone code (e.g. 'CA') but for UK addresses it is zone name (e.g. 'West Midlands'). At least the sandbox API is returning this.
On top of that many zones/states in different countries uses the same zone codes.
The DB query at EC review stage should take this into account when saving the delivery zone for order, otherwise the wrong zone_id is saved.
Here's the patch that solves this by slightly optimized SQL query.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 515128_paypal_ec_zone_id.patch | 1.14 KB | Island Usurper |
| #1 | 515128-paypalEC_correct_zone_id.patch | 1014 bytes | lop |
Comments
Comment #1
lop commentedComment #2
Island Usurper commentedI don't think running check_plain() on the response is a good idea here. Any
&s in the name would be htmlencoded, and they wouldn't match anything in the database. db_query() with the %s automatically makes sure that the input won't harm the query or allow SQL injection.Otherwise, I think this looks like a good idea.
Comment #3
Island Usurper commentedComment #4
Island Usurper commentedHere's the patch without check_plain(). Somebody who has a PayPal sandbox set up, please review this.
Comment #5
Island Usurper commentedRather, here.
Comment #6
rszrama commentedCommitted w/ minor tweak of $country_state -> $zone and initializing the $zone_id variable.